From: Jakub Kicinski <kuba@kernel.org>
To: Jason Gunthorpe <jgg@nvidia.com>
Cc: Saeed Mahameed <saeed@kernel.org>,
Leon Romanovsky <leon@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>,
Saeed Mahameed <saeedm@nvidia.com>,
linux-rdma@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: pull-request: mlx5-next 2023-01-24 V2
Date: Wed, 8 Feb 2023 16:48:07 -0800 [thread overview]
Message-ID: <20230208164807.291d232f@kernel.org> (raw)
In-Reply-To: <Y+Q95U+61VaLC+RJ@nvidia.com>
On Wed, 8 Feb 2023 20:27:17 -0400 Jason Gunthorpe wrote:
> On Wed, Feb 08, 2023 at 03:19:22PM -0800, Jakub Kicinski wrote:
> > On Wed, 8 Feb 2023 12:13:00 -0400 Jason Gunthorpe wrote:
> > > I can't accept yours because it means RDMA stops existing. So we must
> > > continue with what has been done for the last 15 years - RDMA
> > > (selectively) mirrors the IP and everything running at or below the IP
> > > header level.
> >
> > Re-implement bits you need for configuration, not stop existing.
>
> This is completely technically infeasible. They share IP addresess, we
> cannot have two stacks running IPSEC on top of othe same IP address
> without co-ordinating. Almost every part is like that to some degree.
>
> And even if we somehow did keep things 100% seperated, with seperated
> IPs - Linus isn't going to let me copy and paste the huge swaths of
> core netdev code required to do IP stuff (arp, nd, routing, icmp,
> bonding, etc) into RDMA for a reason like this.
>
> So, it really is a complete death blow to demand to keep these things
> separated.
>
> Let alone what would happen if we applied the same logic to all the
> places sharing the IP with HW - remember iscsi? FCoE?
Who said IP configuration.
> > > What do you mean? "make it all the same" can be done with private or
> > > open standards?
> >
> > Oh. If it's someone private specs its probably irrelevant to the open
> > source community?
>
> No, it's what I said I dislike. Private specs, private HW, private
> userspace, proprietary kernel forks, but people still try to get
> incomplete pieces of stuff into the mainline kernel.
>
> > Sad situation. Not my employer and not in netdev, I hope.
>
> AFAIK your and my employer have done a good job together on joint
> projects over the years and have managed to end up with open source
> user spaces for almost everything subtantive in the kernel.
Great. Let's make a note of that so there are not more accusations
that my objectives for netdev are somehow driven by evil hyperscalers.
> > > I have no idea how you are jumping to some conclusion that since the
> > > RDMA team made their patches it somehow has anything to do with the
> > > work Leon and the netdev team will deliver in future?
> >
> > We shouldn't reneg what was agreed on earlier.
>
> Who reneg'd? We always said we'd do it and we are still saying we plan
> to do it.
>
> > > Hasn't our netdev team done enough work on TC stuff to earn some
> > > faith that we do actually care about TC as part of our portfolio?
> >
> > Shouldn't have brought it up in the past discussion then :|
> > Being asked to implement something tangential to your goals for
> > the community to accept your code is hardly unheard of.
>
> We agreed to implement. I'm asking for patience since we have a good
> historical track record.
If you can't make a strong commitment, what's the point in time,
at which if I were angry that the tc redirect was not posted yet -
you'd consider it understandable?
Perhaps that's sufficiently not legally binding? :)
next prev parent reply other threads:[~2023-02-09 0:48 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-26 23:08 pull-request: mlx5-next 2023-01-24 V2 Saeed Mahameed
2023-02-02 7:46 ` Leon Romanovsky
2023-02-02 17:13 ` Jakub Kicinski
2023-02-02 17:14 ` Jason Gunthorpe
2023-02-02 17:25 ` Jakub Kicinski
2023-02-02 17:44 ` Jason Gunthorpe
2023-02-02 17:54 ` Jakub Kicinski
2023-02-02 18:03 ` Leon Romanovsky
2023-02-02 18:15 ` Saeed Mahameed
2023-02-02 18:30 ` Jakub Kicinski
2023-02-03 20:05 ` Saeed Mahameed
2023-02-03 21:14 ` Jakub Kicinski
2023-02-04 0:18 ` Jason Gunthorpe
2023-02-04 1:45 ` Jakub Kicinski
2023-02-06 14:58 ` Jason Gunthorpe
2023-02-07 0:38 ` Jakub Kicinski
2023-02-07 19:52 ` Jason Gunthorpe
2023-02-07 22:03 ` Jakub Kicinski
2023-02-08 9:17 ` Leon Romanovsky
2023-02-08 16:13 ` Jason Gunthorpe
2023-02-08 23:19 ` Jakub Kicinski
2023-02-09 0:27 ` Jason Gunthorpe
2023-02-09 0:48 ` Jakub Kicinski [this message]
2023-02-09 0:59 ` Jason Gunthorpe
2023-02-09 1:16 ` Jakub Kicinski
2023-02-10 17:15 ` Jason Gunthorpe
2023-02-09 0:36 ` Saeed Mahameed
2023-02-09 0:52 ` Jakub Kicinski
2023-02-04 0:47 ` Saeed Mahameed
2023-02-04 1:57 ` Jakub Kicinski
2023-02-05 10:26 ` Leon Romanovsky
2023-02-02 18:07 ` Leon Romanovsky
2023-02-03 20:14 ` Saeed Mahameed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230208164807.291d232f@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jgg@nvidia.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeed@kernel.org \
--cc=saeedm@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).