From: Tony Nguyen <anthony.l.nguyen@intel.com>
To: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
edumazet@google.com
Cc: Tony Nguyen <anthony.l.nguyen@intel.com>,
netdev@vger.kernel.org, paul.m.stillwell.jr@intel.com,
jacob.e.keller@intel.com, jiri@nvidia.com, idosch@idosch.org
Subject: [PATCH net-next 0/5][pull request] add v2 FW logging for ice driver
Date: Thu, 9 Feb 2023 11:06:57 -0800 [thread overview]
Message-ID: <20230209190702.3638688-1-anthony.l.nguyen@intel.com> (raw)
Paul Stillwell says:
FW log support was added to the ice driver, but that version is no
longer supported. There is a newer version of FW logging (v2) that
adds more control knobs to get the exact data out of the FW
for debugging.
Additionally, instead of dumping the FW log output to syslog,
dump it to debugfs. The FW log data is really just binary
data that the FW log team decodes to determine what happens so the
translation from binary to some text output just slows things down
and results in potential dropped data. The structure for the debugfs
entry is: /sys/kernel/debug/ice/<pci device>/fwlog
Once enabled the FW log data is received as ARQ events that the driver
processes.
The FW logging is across all the PFs on the device, so restrict the
commands to only PF0.
The following new device parameters are added:
- fwlog_supported (read-only): does the FW support FW logging
- fwlog_enabled (read/write): is FW logging currently running
- fwlog_level (read/write): the log level enabled, valid values are
Each level includes the messages from the previous/lower level
0 - no logging
1 - error logging
2 - warning logging
3 - normal logging
4 - verbose logging
- fwlog_resolution (read/write): the number of log messages to included
in a single ARQ event. The range is 1-128 (1 means push every log
message, 128 means push only when the max AQ command buffer is full).
The suggested value is 10.
This patch series adds the following set of devlink commands:
devlink dev param set <pci dev> name fwlog_enabled value <true/false> cmode runtime
devlink dev param set <pci dev> name fwlog_level value <0-4> cmode runtime
devlink dev param set <pci dev> name fwlog_resolution value <1-128> cmode runtime
---
Previous discussion:
https://lore.kernel.org/netdev/fea3e7bc-db75-ce15-1330-d80483267ee2@intel.com/
The following are changes since commit 5131a053f2927158fb42880c69b5dc0d2e28ddee:
Merge tag 'linux-can-next-for-6.3-20230208' of git://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can-next
and are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/tnguy/next-queue 100GbE
Paul M Stillwell Jr (5):
ice: remove FW logging code
ice: enable devlink to check FW logging status
ice: add ability to query/set FW log level and resolution
ice: disable FW logging on driver unload
ice: use debugfs to output FW log data
Documentation/networking/devlink/ice.rst | 39 ++
drivers/net/ethernet/intel/ice/Makefile | 5 +-
drivers/net/ethernet/intel/ice/ice.h | 22 ++
.../net/ethernet/intel/ice/ice_adminq_cmd.h | 160 ++++----
drivers/net/ethernet/intel/ice/ice_common.c | 218 +----------
drivers/net/ethernet/intel/ice/ice_common.h | 1 -
drivers/net/ethernet/intel/ice/ice_debugfs.c | 116 ++++++
drivers/net/ethernet/intel/ice/ice_devlink.c | 181 ++++++++-
drivers/net/ethernet/intel/ice/ice_fwlog.c | 367 ++++++++++++++++++
drivers/net/ethernet/intel/ice/ice_fwlog.h | 57 +++
drivers/net/ethernet/intel/ice/ice_main.c | 101 ++++-
drivers/net/ethernet/intel/ice/ice_type.h | 23 +-
12 files changed, 973 insertions(+), 317 deletions(-)
create mode 100644 drivers/net/ethernet/intel/ice/ice_debugfs.c
create mode 100644 drivers/net/ethernet/intel/ice/ice_fwlog.c
create mode 100644 drivers/net/ethernet/intel/ice/ice_fwlog.h
--
2.38.1
next reply other threads:[~2023-02-09 19:07 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-09 19:06 Tony Nguyen [this message]
2023-02-09 19:06 ` [PATCH net-next 1/5] ice: remove FW logging code Tony Nguyen
2023-02-09 19:06 ` [PATCH net-next 2/5] ice: enable devlink to check FW logging status Tony Nguyen
2023-02-09 19:07 ` [PATCH net-next 3/5] ice: add ability to query/set FW log level and resolution Tony Nguyen
2023-02-09 19:07 ` [PATCH net-next 4/5] ice: disable FW logging on driver unload Tony Nguyen
2023-02-09 19:07 ` [PATCH net-next 5/5] ice: use debugfs to output FW log data Tony Nguyen
2023-02-11 4:23 ` [PATCH net-next 0/5][pull request] add v2 FW logging for ice driver Jakub Kicinski
2023-02-13 23:46 ` Paul M Stillwell Jr
2023-02-14 0:40 ` Jakub Kicinski
2023-02-14 16:14 ` Paul M Stillwell Jr
2023-02-14 20:44 ` Jakub Kicinski
2023-02-14 22:39 ` Jacob Keller
2023-02-14 23:19 ` Jakub Kicinski
2023-02-15 0:07 ` Jacob Keller
2023-02-15 1:16 ` Jakub Kicinski
2023-02-15 1:33 ` Jacob Keller
2023-02-15 2:07 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230209190702.3638688-1-anthony.l.nguyen@intel.com \
--to=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=idosch@idosch.org \
--cc=jacob.e.keller@intel.com \
--cc=jiri@nvidia.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=paul.m.stillwell.jr@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).