From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 044D5C6379F for ; Wed, 15 Feb 2023 02:41:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229648AbjBOClb (ORCPT ); Tue, 14 Feb 2023 21:41:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33756 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229493AbjBOCla (ORCPT ); Tue, 14 Feb 2023 21:41:30 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5E9C827D6E; Tue, 14 Feb 2023 18:41:30 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id EEC48619AC; Wed, 15 Feb 2023 02:41:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1ADE3C433D2; Wed, 15 Feb 2023 02:41:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1676428889; bh=wWD/OfXPqNsPHWvTUEODuneuyI/n26v4Hg5Tl/XoJIs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=MeoNHJbCnBzJAwmp8++AYNciPQtge44PnNvboq2u03dqtl8Pbea9nmB9UoZfUKmoa 2xy+l7EdKgZJBB5gICf0hgxKgEjhlEDpOZEoxwhLIZtft3Km9aiCq8ZmnPxkX2dUUG aqbCHCFN/MzLXC4y9qVSOhEvuONi3nMtPAKDzY+kxPWTfBbHco31yzk/+7Q22mo1fR uxKHF06G/OeOEPyON2xEEnK36cE1H5+EkPYnXrSJ1AehtroRk6cFf/+BgGQdSYeIr/ ncAl8qrd01snNrUyXOX8Otacurtg7myguV35By98hKh2af9znpOCOSAE4ldB0u2lmU fWGM3DNWQRaiQ== Date: Tue, 14 Feb 2023 18:41:28 -0800 From: Jakub Kicinski To: mchehab@kernel.org Cc: netdev@vger.kernel.org, hverkuil@xs4all.nl, gregkh@linuxfoundation.org, linux-media@vger.kernel.org, linux-staging@lists.linux.dev Subject: Re: [PATCH] media: drop unnecessary networking includes Message-ID: <20230214184128.45cabcf8@kernel.org> In-Reply-To: <20230203233129.3413367-1-kuba@kernel.org> References: <20230203233129.3413367-1-kuba@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, 3 Feb 2023 15:31:29 -0800 Jakub Kicinski wrote: > dvb_net.h includes a bunch of core networking headers which increases > the number of objects rebuilt when we touch them. They are unnecessary > for the header itself and only one driver has an indirect dependency. > > tveeprom.h includes if_packet to gain access to ETH_ALEN. This > is a bit of an overkill because if_packet.h pulls in skbuff.h. > The definition of ETH_ALEN is in the uAPI header, which is > very rarely touched, so switch to including that. > > This results in roughly 250 fewer objects built when skbuff.h > is touched (6028 -> 5788). > > Signed-off-by: Jakub Kicinski Hi Mauro! Could you take this in for 6.3? Is it okay if we queue it via the networking tree otherwise?