From: "Ricardo Cañuelo" <ricardo.canuelo@collabora.com>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: "David S . Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Arnd Bergmann" <arnd@arndb.de>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Jon Mason" <jon.mason@broadcom.com>,
netdev@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com,
"Rafał Miłecki" <rafal@milecki.pl>,
"Jon Mason" <jdmason@kudzu.us>
Subject: Re: [PATCH net] bgmac: fix *initial* chip reset to support BCM5358
Date: Tue, 4 Apr 2023 15:46:13 +0200 [thread overview]
Message-ID: <20230404134613.wtikjp6v63isofoc@rcn-XPS-13-9305> (raw)
In-Reply-To: <20230227091156.19509-1-zajec5@gmail.com>
Hi Rafał,
On mar 07-02-2023 23:53:27, Rafał Miłecki wrote:
> While bringing hardware up we should perform a full reset including the
> switch bit (BGMAC_BCMA_IOCTL_SW_RESET aka SICF_SWRST). It's what
> specification says and what reference driver does.
>
> This seems to be critical for the BCM5358. Without this hardware doesn't
> get initialized properly and doesn't seem to transmit or receive any
> packets.
>
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
KernelCI found this patch causes a regression in the
bootrr.deferred-probe-empty test [1] on sun8i-h3-libretech-all-h3-cc
[2], see the bisection report for more details [3]
Does it make sense to you?
Cheers,
Ricardo
[1] https://github.com/kernelci/bootrr/blob/3ae9fd5dffc667fa96012892ea08532bc6877276/helpers/bootrr-generic-tests#L3
[2] https://linux.kernelci.org/test/case/id/642a0f5c78c0feaf5d62f79c/
[3] https://groups.io/g/kernelci-results/message/40156
#regzbot introduced: f6a95a24957a
next prev parent reply other threads:[~2023-04-04 13:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-27 9:11 [PATCH net] bgmac: fix *initial* chip reset to support BCM5358 Rafał Miłecki
2023-02-27 9:54 ` Leon Romanovsky
2023-02-27 18:23 ` Florian Fainelli
2023-02-28 10:30 ` patchwork-bot+netdevbpf
2023-04-04 13:46 ` Ricardo Cañuelo [this message]
2023-04-04 13:52 ` Rafał Miłecki
2023-04-05 12:42 ` Florian Fainelli
2023-04-14 14:04 ` Linux regression tracking (Thorsten Leemhuis)
2023-04-14 14:08 ` Ricardo Cañuelo
2023-04-14 14:12 ` Linux regression tracking #update (Thorsten Leemhuis)
2023-04-05 11:16 ` Linux regression tracking #update (Thorsten Leemhuis)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230404134613.wtikjp6v63isofoc@rcn-XPS-13-9305 \
--to=ricardo.canuelo@collabora.com \
--cc=arnd@arndb.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=jdmason@kudzu.us \
--cc=jon.mason@broadcom.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rafal@milecki.pl \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).