From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: Ido Schimmel <idosch@nvidia.com>
Cc: netdev@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
"Hans J. Schultz" <netdev@kapio-technology.com>,
Roopa Prabhu <roopa@nvidia.com>,
Nikolay Aleksandrov <razor@blackwall.org>,
Ivan Vecera <ivecera@redhat.com>, Jiri Pirko <jiri@resnulli.us>,
Arkadi Sharshevsky <arkadis@mellanox.com>,
Ido Schimmel <idosch@mellanox.com>,
bridge@lists.linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] net: bridge: switchdev: don't notify FDB entries with "master dynamic"
Date: Wed, 12 Apr 2023 20:04:37 +0300 [thread overview]
Message-ID: <20230412170437.26nwldbxydm7lgxm@skbuf> (raw)
In-Reply-To: <ZDbhDUDs0RUWVZ4B@shredder>
On Wed, Apr 12, 2023 at 07:49:17PM +0300, Ido Schimmel wrote:
> On Wed, Apr 12, 2023 at 07:24:07PM +0300, Vladimir Oltean wrote:
> > I'll send v2 with BR_FDB_ADDED_BY_EXT_LEARN not prevented from being
> > notified from switchdev.
> >
> > Unless you have any objection, I won't send v2 like this:
> >
> > if (test_bit(BR_FDB_ADDED_BY_USER, &fdb->flags) &&
> > !test_bit(BR_FDB_STATIC, &fdb->flags) &&
> > !test_bit(BR_FDB_ADDED_BY_EXT_LEARN, &fdb->flags))
> > return;
> >
> > but like this:
> >
> > /* Entries with just the BR_FDB_ADDED_BY_USER flag set were created
> > * using 'bridge fdb add ... master dynamic'
> > */
> > if (fdb->flags == BIT(BR_FDB_ADDED_BY_USER))
> > return;
>
> LGTM. Please copy me on v2 and I will run it through regression. Will
> try to report results before tomorrow's PR.
Sorry, I won't send the v2 early; I need to think more about this and
I don't want to rush things. It's likely that the zero-day bug fix will
miss this week's PR.
prev parent reply other threads:[~2023-04-12 17:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-10 20:49 [PATCH net] net: bridge: switchdev: don't notify FDB entries with "master dynamic" Vladimir Oltean
2023-04-11 15:30 ` Jesse Brandeburg
2023-04-12 14:15 ` Ido Schimmel
2023-04-12 14:27 ` Vladimir Oltean
2023-04-12 16:00 ` Ido Schimmel
2023-04-12 16:24 ` Vladimir Oltean
2023-04-12 16:49 ` Ido Schimmel
2023-04-12 17:04 ` Vladimir Oltean [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230412170437.26nwldbxydm7lgxm@skbuf \
--to=vladimir.oltean@nxp.com \
--cc=arkadis@mellanox.com \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=idosch@mellanox.com \
--cc=idosch@nvidia.com \
--cc=ivecera@redhat.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@kapio-technology.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=razor@blackwall.org \
--cc=roopa@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).