From: Matthieu Baerts <matthieu.baerts@tessares.net>
To: mptcp@lists.linux.dev, Mat Martineau <martineau@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>, Shuah Khan <shuah@kernel.org>,
Davide Caratti <dcaratti@redhat.com>,
Dmytro Shytyi <dmytro@shytyi.net>,
Menglong Dong <imagedong@tencent.com>,
Geliang Tang <geliang.tang@suse.com>,
Kishen Maloor <kishen.maloor@intel.com>
Cc: Florian Westphal <fw@strlen.de>,
netdev@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org,
Matthieu Baerts <matthieu.baerts@tessares.net>,
stable@vger.kernel.org
Subject: [PATCH net 12/14] selftests: mptcp: userspace pm: skip if 'ip' tool is unavailable
Date: Thu, 08 Jun 2023 18:38:54 +0200 [thread overview]
Message-ID: <20230608-upstream-net-20230608-mptcp-selftests-support-old-kernels-part-2-v1-12-20997a6fd841@tessares.net> (raw)
In-Reply-To: <20230608-upstream-net-20230608-mptcp-selftests-support-old-kernels-part-2-v1-0-20997a6fd841@tessares.net>
When a required tool is missing, the return code 4 (SKIP) should be
returned instead of 1 (FAIL).
Link: https://github.com/multipath-tcp/mptcp_net-next/issues/368
Fixes: 259a834fadda ("selftests: mptcp: functional tests for the userspace PM type")
Cc: stable@vger.kernel.org
Signed-off-by: Matthieu Baerts <matthieu.baerts@tessares.net>
---
tools/testing/selftests/net/mptcp/userspace_pm.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/net/mptcp/userspace_pm.sh b/tools/testing/selftests/net/mptcp/userspace_pm.sh
index 8092399d911f..192ab818f292 100755
--- a/tools/testing/selftests/net/mptcp/userspace_pm.sh
+++ b/tools/testing/selftests/net/mptcp/userspace_pm.sh
@@ -8,7 +8,7 @@ mptcp_lib_check_mptcp
ip -Version > /dev/null 2>&1
if [ $? -ne 0 ];then
echo "SKIP: Cannot not run test without ip tool"
- exit 1
+ exit ${KSFT_SKIP}
fi
ANNOUNCED=6 # MPTCP_EVENT_ANNOUNCED
--
2.40.1
next prev parent reply other threads:[~2023-06-08 16:39 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-08 16:38 [PATCH net 00/14] selftests: mptcp: skip tests not supported by old kernels (part 2) Matthieu Baerts
2023-06-08 16:38 ` [PATCH net 01/14] selftests: mptcp: lib: skip if missing symbol Matthieu Baerts
2023-06-08 16:38 ` [PATCH net 02/14] selftests: mptcp: connect: skip transp tests if not supported Matthieu Baerts
2023-06-08 16:38 ` [PATCH net 03/14] selftests: mptcp: connect: skip disconnect " Matthieu Baerts
2023-06-08 16:38 ` [PATCH net 04/14] selftests: mptcp: connect: skip TFO " Matthieu Baerts
2023-06-08 16:38 ` [PATCH net 05/14] selftests: mptcp: diag: skip listen " Matthieu Baerts
2023-06-08 16:38 ` [PATCH net 06/14] selftests: mptcp: diag: skip inuse " Matthieu Baerts
2023-06-08 16:38 ` [PATCH net 07/14] selftests: mptcp: pm nl: remove hardcoded default limits Matthieu Baerts
2023-06-08 16:38 ` [PATCH net 08/14] selftests: mptcp: pm nl: skip fullmesh flag checks if not supported Matthieu Baerts
2023-06-08 16:38 ` [PATCH net 09/14] selftests: mptcp: sockopt: relax expected returned size Matthieu Baerts
2023-06-08 16:38 ` [PATCH net 10/14] selftests: mptcp: sockopt: skip getsockopt checks if not supported Matthieu Baerts
2023-06-08 16:38 ` [PATCH net 11/14] selftests: mptcp: sockopt: skip TCP_INQ " Matthieu Baerts
2023-06-08 16:38 ` Matthieu Baerts [this message]
2023-06-08 16:38 ` [PATCH net 13/14] selftests: mptcp: userspace pm: skip " Matthieu Baerts
2023-06-08 16:38 ` [PATCH net 14/14] selftests: mptcp: userspace pm: skip PM listener events tests if unavailable Matthieu Baerts
2023-06-10 7:12 ` [PATCH net 00/14] selftests: mptcp: skip tests not supported by old kernels (part 2) patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230608-upstream-net-20230608-mptcp-selftests-support-old-kernels-part-2-v1-12-20997a6fd841@tessares.net \
--to=matthieu.baerts@tessares.net \
--cc=davem@davemloft.net \
--cc=dcaratti@redhat.com \
--cc=dmytro@shytyi.net \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=geliang.tang@suse.com \
--cc=imagedong@tencent.com \
--cc=kishen.maloor@intel.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=martineau@kernel.org \
--cc=mptcp@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).