From: Steven Rostedt <rostedt@goodmis.org>
To: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Jiri Olsa <jolsa@kernel.org>, Alexei Starovoitov <ast@kernel.org>,
Andrii Nakryiko <andrii.nakryiko@gmail.com>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
netdev@vger.kernel.org, bpf@vger.kernel.org,
lkml <linux-kernel@vger.kernel.org>,
Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
Yonghong Song <yhs@fb.com>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@chromium.org>,
"Naveen N . Rao" <naveen.n.rao@linux.ibm.com>,
Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>,
"David S . Miller" <davem@davemloft.net>
Subject: Re: [PATCH v12 bpf-next 02/12] fprobe: Add ftrace based probe APIs
Date: Thu, 8 Jun 2023 18:51:42 -0400 [thread overview]
Message-ID: <20230608185142.7372e7b6@gandalf.local.home> (raw)
In-Reply-To: <164735283857.1084943.1154436951479395551.stgit@devnote2>
On Tue, 15 Mar 2022 23:00:38 +0900
Masami Hiramatsu <mhiramat@kernel.org> wrote:
> +static void fprobe_init(struct fprobe *fp)
> +{
> + fp->nmissed = 0;
> + fp->ops.func = fprobe_handler;
> + fp->ops.flags |= FTRACE_OPS_FL_SAVE_REGS;
> +}
> +
Masami,
I thought one of the advantages of fprobes over kprobes was that it did not
need to use SAVE_REGS, as that causes more overhead than SAVE_ARGS?
If fprobes uses save regs, what is the advantage of it over kprobes?
-- Steve
next prev parent reply other threads:[~2023-06-08 22:51 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-15 14:00 [PATCH v12 bpf-next 00/12] fprobe: Introduce fprobe function entry/exit probe Masami Hiramatsu
2022-03-15 14:00 ` [PATCH v12 bpf-next 01/12] ftrace: Add ftrace_set_filter_ips function Masami Hiramatsu
2022-03-15 14:00 ` [PATCH v12 bpf-next 02/12] fprobe: Add ftrace based probe APIs Masami Hiramatsu
2023-06-08 22:51 ` Steven Rostedt [this message]
2022-03-15 14:00 ` [PATCH v12 bpf-next 03/12] rethook: Add a generic return hook Masami Hiramatsu
2022-03-15 14:01 ` [PATCH v12 bpf-next 04/12] rethook: x86: Add rethook x86 implementation Masami Hiramatsu
2022-03-15 14:01 ` [PATCH v12 bpf-next 05/12] arm64: rethook: Add arm64 rethook implementation Masami Hiramatsu
2022-03-15 14:01 ` [PATCH v12 bpf-next 06/12] powerpc: Add rethook support Masami Hiramatsu
2022-03-15 14:01 ` [PATCH v12 bpf-next 07/12] ARM: rethook: Add rethook arm implementation Masami Hiramatsu
2022-03-15 14:01 ` [PATCH v12 bpf-next 08/12] fprobe: Add exit_handler support Masami Hiramatsu
2022-03-15 14:02 ` [PATCH v12 bpf-next 09/12] fprobe: Add sample program for fprobe Masami Hiramatsu
2022-03-15 14:02 ` [PATCH v12 bpf-next 10/12] fprobe: Introduce FPROBE_FL_KPROBE_SHARED flag " Masami Hiramatsu
2022-03-15 14:02 ` [PATCH v12 bpf-next 11/12] docs: fprobe: Add fprobe description to ftrace-use.rst Masami Hiramatsu
2022-03-15 14:02 ` [PATCH v12 bpf-next 12/12] fprobe: Add a selftest for fprobe Masami Hiramatsu
2022-03-15 14:42 ` [PATCH v12 bpf-next 00/12] fprobe: Introduce fprobe function entry/exit probe Masami Hiramatsu
2022-03-18 3:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230608185142.7372e7b6@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=andrii.nakryiko@gmail.com \
--cc=andrii@kernel.org \
--cc=anil.s.keshavamurthy@intel.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kafai@fb.com \
--cc=kpsingh@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=naveen.n.rao@linux.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).