From: Przemek Kitszel <przemyslaw.kitszel@intel.com>
To: Jiri Pirko <jiri@resnulli.us>,
netdev@vger.kernel.org, "David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Shannon Nelson <shannon.nelson@amd.com>,
Michael Chan <michael.chan@broadcom.com>,
Cai Huoqing <cai.huoqing@linux.dev>,
George Cherian <george.cherian@marvell.com>,
Danielle Ratson <danieller@nvidia.com>,
Moshe Shemesh <moshe@nvidia.com>,
Saeed Mahameed <saeedm@nvidia.com>,
Ariel Elior <aelior@marvell.com>,
Manish Chopra <manishc@marvell.com>,
Igor Russkikh <irusskikh@marvell.com>,
Coiby Xu <coiby.xu@gmail.com>
Cc: Brett Creeley <brett.creeley@amd.com>,
Sunil Goutham <sgoutham@marvell.com>,
Linu Cherian <lcherian@marvell.com>,
Geetha sowjanya <gakula@marvell.com>,
Jerin Jacob <jerinj@marvell.com>, hariprasad <hkelam@marvell.com>,
Subbaraya Sundeep <sbhatta@marvell.com>,
Ido Schimmel <idosch@nvidia.com>, Petr Machata <petrm@nvidia.com>,
Eran Ben Elisha <eranbe@nvidia.com>,
Aya Levin <ayal@mellanox.com>, Leon Romanovsky <leon@kernel.org>,
linux-kernel@vger.kernel.org,
Przemek Kitszel <przemyslaw.kitszel@intel.com>
Subject: [PATCH net-next v2 00/11] devlink: retain error in struct devlink_fmsg
Date: Tue, 17 Oct 2023 12:53:30 +0200 [thread overview]
Message-ID: <20231017105341.415466-1-przemyslaw.kitszel@intel.com> (raw)
Extend devlink fmsg to retain error (patch 1),
so drivers could omit error checks after devlink_fmsg_*() (patches 2-10),
and finally enforce future uses to follow this practice by change to
return void (patch 11)
Note that it was compile tested only.
bloat-o-meter for whole series:
add/remove: 8/18 grow/shrink: 23/40 up/down: 2017/-5833 (-3816)
changelog:
v2: extend series by two more drivers (qed, qlge);
add final cleanup patch, since now whole series should be merged in
one part (thanks Jiri for encouragement here);
v1:
https://lore.kernel.org/netdev/20231010104318.3571791-3-przemyslaw.kitszel@intel.com
Przemek Kitszel (11):
devlink: retain error in struct devlink_fmsg
netdevsim: devlink health: use retained error fmsg API
pds_core: devlink health: use retained error fmsg API
bnxt_en: devlink health: use retained error fmsg API
hinic: devlink health: use retained error fmsg API
octeontx2-af: devlink health: use retained error fmsg API
mlxsw: core: devlink health: use retained error fmsg API
net/mlx5: devlink health: use retained error fmsg API
qed: devlink health: use retained error fmsg API
staging: qlge: devlink health: use retained error fmsg API
devlink: convert most of devlink_fmsg_*() to return void
drivers/net/ethernet/amd/pds_core/devlink.c | 29 +-
.../net/ethernet/broadcom/bnxt/bnxt_devlink.c | 93 ++--
.../net/ethernet/huawei/hinic/hinic_devlink.c | 217 +++-----
.../marvell/octeontx2/af/rvu_devlink.c | 464 +++++-------------
.../mellanox/mlx5/core/diag/fw_tracer.c | 49 +-
.../mellanox/mlx5/core/diag/reporter_vnic.c | 118 ++---
.../mellanox/mlx5/core/diag/reporter_vnic.h | 6 +-
.../ethernet/mellanox/mlx5/core/en/health.c | 185 ++-----
.../ethernet/mellanox/mlx5/core/en/health.h | 14 +-
.../mellanox/mlx5/core/en/reporter_rx.c | 426 ++++------------
.../mellanox/mlx5/core/en/reporter_tx.c | 346 ++++---------
.../net/ethernet/mellanox/mlx5/core/en_rep.c | 5 +-
.../net/ethernet/mellanox/mlx5/core/health.c | 127 ++---
drivers/net/ethernet/mellanox/mlxsw/core.c | 171 ++-----
drivers/net/ethernet/qlogic/qed/qed_devlink.c | 6 +-
drivers/net/netdevsim/health.c | 118 ++---
drivers/staging/qlge/qlge_devlink.c | 60 +--
include/net/devlink.h | 60 +--
net/devlink/health.c | 388 +++++----------
19 files changed, 822 insertions(+), 2060 deletions(-)
--
2.40.1
next reply other threads:[~2023-10-17 10:54 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-17 10:53 Przemek Kitszel [this message]
2023-10-17 10:53 ` [PATCH net-next v2 01/11] devlink: retain error in struct devlink_fmsg Przemek Kitszel
2023-10-17 10:53 ` [PATCH net-next v2 02/11] netdevsim: devlink health: use retained error fmsg API Przemek Kitszel
2023-10-18 1:20 ` Jakub Kicinski
2023-10-17 10:53 ` [PATCH net-next v2 03/11] pds_core: " Przemek Kitszel
2023-10-17 11:06 ` Jiri Pirko
2023-10-17 11:15 ` Jiri Pirko
2023-10-17 11:35 ` Przemek Kitszel
2023-10-17 16:52 ` Nelson, Shannon
2023-10-17 10:53 ` [PATCH net-next v2 04/11] bnxt_en: " Przemek Kitszel
2023-10-17 10:53 ` [PATCH net-next v2 05/11] hinic: " Przemek Kitszel
2023-10-17 10:53 ` [PATCH net-next v2 06/11] octeontx2-af: " Przemek Kitszel
2023-10-17 10:53 ` [PATCH net-next v2 07/11] mlxsw: core: " Przemek Kitszel
2023-10-17 10:53 ` [PATCH net-next v2 08/11] net/mlx5: " Przemek Kitszel
2023-10-18 16:08 ` Simon Horman
2023-10-17 10:53 ` [PATCH net-next v2 09/11] qed: " Przemek Kitszel
2023-10-17 10:53 ` [PATCH net-next v2 10/11] staging: qlge: " Przemek Kitszel
2023-10-18 1:15 ` Jakub Kicinski
2023-10-19 14:28 ` Benjamin Poirier
2023-10-19 14:42 ` Jakub Kicinski
2023-10-19 18:32 ` Benjamin Poirier
2023-10-17 10:53 ` [PATCH net-next v2 11/11] devlink: convert most of devlink_fmsg_*() to return void Przemek Kitszel
2023-10-18 16:10 ` Simon Horman
2023-10-17 11:17 ` [PATCH net-next v2 00/11] devlink: retain error in struct devlink_fmsg Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231017105341.415466-1-przemyslaw.kitszel@intel.com \
--to=przemyslaw.kitszel@intel.com \
--cc=aelior@marvell.com \
--cc=ayal@mellanox.com \
--cc=brett.creeley@amd.com \
--cc=cai.huoqing@linux.dev \
--cc=coiby.xu@gmail.com \
--cc=danieller@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eranbe@nvidia.com \
--cc=gakula@marvell.com \
--cc=george.cherian@marvell.com \
--cc=hkelam@marvell.com \
--cc=idosch@nvidia.com \
--cc=irusskikh@marvell.com \
--cc=jerinj@marvell.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=lcherian@marvell.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manishc@marvell.com \
--cc=michael.chan@broadcom.com \
--cc=moshe@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=saeedm@nvidia.com \
--cc=sbhatta@marvell.com \
--cc=sgoutham@marvell.com \
--cc=shannon.nelson@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).