From: Jakub Kicinski <kuba@kernel.org>
To: Davide Caratti <dcaratti@redhat.com>
Cc: Jamal Hadi Salim <jhs@mojatatu.com>,
davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com,
Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>,
xiyou.wangcong@gmail.com, jiri@resnulli.us,
shmulik.ladkani@gmail.com
Subject: Re: [PATCH net] net/sched: act_mirred: use the backlog for mirred ingress
Date: Wed, 14 Feb 2024 16:31:32 -0800 [thread overview]
Message-ID: <20240214163132.54fd74bc@kernel.org> (raw)
In-Reply-To: <Zczl_QQ200PvyzH5@dcaratti.users.ipa.redhat.com>
On Wed, 14 Feb 2024 17:10:37 +0100 Davide Caratti wrote:
> > So tests pass - but on the list i only see one patch and the other is
> > on lore, not sure how to ACK something that is not on email, but FWIW:
> > Acked-by: Jamal Hadi Salim <jhs@mojatatu.com>
> >
> > The second patch avoids the recursion issue (which was the root cause)
> > and the first patch is really undoing ca22da2fbd693
>
> If I well read, Jakub's patch [1] uses the backlog for egress->ingress
> regardless of the "nest level": no more calls to netif_receive_skb():
> It's the same as my initial proposal for fixing the OVS soft-lockup [2],
> the code is different because now we have tcf_mirred_to_dev().
FWIW feel free to add your Sob or Co-dev+Sob!
It is very much the same solution as what you posted at some stage.
next prev parent reply other threads:[~2024-02-15 0:31 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-09 23:54 [PATCH net] net/sched: act_mirred: use the backlog for mirred ingress Jakub Kicinski
2024-02-12 14:51 ` Jamal Hadi Salim
2024-02-12 15:02 ` Jakub Kicinski
2024-02-12 15:11 ` Jamal Hadi Salim
2024-02-13 11:06 ` Paolo Abeni
2024-02-14 0:27 ` Jakub Kicinski
2024-02-14 3:40 ` Jakub Kicinski
2024-02-14 15:11 ` Jamal Hadi Salim
2024-02-14 15:28 ` Jamal Hadi Salim
2024-02-14 16:10 ` Davide Caratti
2024-02-15 0:31 ` Jakub Kicinski [this message]
2024-02-15 17:55 ` Davide Caratti
-- strict thread matches above, loose matches on Subject: below --
2022-09-23 15:11 Davide Caratti
2022-09-25 18:08 ` Cong Wang
2022-10-04 17:40 ` Davide Caratti
2022-10-16 17:28 ` Cong Wang
2022-11-18 23:07 ` Peilin Ye
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240214163132.54fd74bc@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=dcaratti@redhat.com \
--cc=edumazet@google.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=marcelo.leitner@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shmulik.ladkani@gmail.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).