From: Jakub Kicinski <kuba@kernel.org>
To: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Cc: <davem@davemloft.net>, <netdev@vger.kernel.org>,
<edumazet@google.com>, <pabeni@redhat.com>,
<amritha.nambiar@intel.com>, <danielj@nvidia.com>,
<mst@redhat.com>, <michael.chan@broadcom.com>, <sdf@google.com>,
<vadim.fedorenko@linux.dev>
Subject: Re: [PATCH net-next 1/3] netdev: add per-queue statistics
Date: Tue, 27 Feb 2024 15:01:44 -0800 [thread overview]
Message-ID: <20240227150144.01b33697@kernel.org> (raw)
In-Reply-To: <6dcf163a-c089-4047-a3d7-ee492778db48@intel.com>
On Tue, 27 Feb 2024 17:17:38 +0100 Przemek Kitszel wrote:
> >> I get it, but encouraging users to reset those on queue-count-change
> >> seems to cover that case too. I'm fine though :P
> >
> > What do you mean? Did I encourage the users somewhere?
>
> I mean that instead of 'driver should reset on q num change' we could
> have 'user should reset stats if wants them zeroed' :)
>
> but this is not a strong opinion
Let's revisit the recommendation once we actually have that API for
resetting? :)
next prev parent reply other threads:[~2024-02-27 23:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-26 21:10 [PATCH net-next 0/3] netdev: add per-queue statistics Jakub Kicinski
2024-02-26 21:10 ` [PATCH net-next 1/3] " Jakub Kicinski
2024-02-26 21:35 ` Stanislav Fomichev
2024-02-26 22:19 ` Jakub Kicinski
2024-02-27 3:37 ` Stanislav Fomichev
2024-02-27 15:24 ` Jakub Kicinski
2024-02-27 18:09 ` Stanislav Fomichev
2024-02-27 19:49 ` Nambiar, Amritha
2024-02-27 10:29 ` Przemek Kitszel
2024-02-27 15:00 ` Jakub Kicinski
2024-02-27 16:17 ` Przemek Kitszel
2024-02-27 23:01 ` Jakub Kicinski [this message]
2024-02-26 21:10 ` [PATCH net-next 2/3] netdev: add queue stat for alloc failures Jakub Kicinski
2024-02-26 21:10 ` [PATCH net-next 3/3] eth: bnxt: support per-queue statistics Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240227150144.01b33697@kernel.org \
--to=kuba@kernel.org \
--cc=amritha.nambiar@intel.com \
--cc=danielj@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=michael.chan@broadcom.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=sdf@google.com \
--cc=vadim.fedorenko@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).