From: John Ernberg <john.ernberg@actia.se>
To: Wei Fang <wei.fang@nxp.com>
Cc: Shenwei Wang <shenwei.wang@nxp.com>,
Clark Wang <xiaoning.wang@nxp.com>,
NXP Linux Team <linux-imx@nxp.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
John Ernberg <john.ernberg@actia.se>
Subject: [PATCH net v3 0/2] net: fec: Fixes to suspend / resume with mac_managed_pm
Date: Wed, 6 Mar 2024 13:37:45 +0000 [thread overview]
Message-ID: <20240306133734.4144808-1-john.ernberg@actia.se> (raw)
Since the introduction of mac_managed_pm in the FEC driver there were some
discrepancies regarding power management of the PHY.
This failed on our board that has a permanently powered Microchip LAN8700R
attached to the FEC. Although the root cause of the failure can be traced
back to f166f890c8f0 ("net: ethernet: fec: Replace interrupt driven MDIO
with polled IO") and probably even before that, we only started noticing
the problem going from 5.10 to 6.1.
Since 557d5dc83f68 ("net: fec: use mac-managed PHY PM") is actually a fix
to most of the power management sequencing problems that came with power
managing the MDIO bus which for the FEC meant adding a race with FEC
resume (and phy_start() if netif was running) and PHY resume.
That it worked before for us was probably just luck...
Thanks to Wei's response to my report at [1] I was able to pick up his
patch and start honing in on the remaining missing details.
[1]: https://lore.kernel.org/netdev/1f45bdbe-eab1-4e59-8f24-add177590d27@actia.se/
v3:
- Implement feedback from Wei Fang for patch 2
- Fixes tag in patch 2 dropped, should it be delayed for net-next now?
v2: https://lore.kernel.org/netdev/20240229105256.2903095-1-john.ernberg@actia.se/
- Completely different approach that should be much more correct
(Wei Fang, Jakub Kicinski)
- Re-target to net tree, because I have fixes tags now
v1: https://lore.kernel.org/netdev/20240212105010.2258421-1-john.ernberg@actia.se/
John Ernberg (1):
net: fec: Suspend the PHY on probe
Wei Fang (1):
net: fec: Set mac_managed_pm during probe
drivers/net/ethernet/freescale/fec_main.c | 13 +++++++++++--
1 file changed, 11 insertions(+), 2 deletions(-)
--
2.43.0
next reply other threads:[~2024-03-06 13:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-06 13:37 John Ernberg [this message]
2024-03-06 13:37 ` [PATCH net v3 1/2] net: fec: Set mac_managed_pm during probe John Ernberg
2024-03-06 13:37 ` [PATCH net v3 2/2] net: fec: Suspend the PHY on probe John Ernberg
2024-03-06 18:05 ` Maxime Chevallier
2024-03-19 8:37 ` John Ernberg
2024-03-19 8:51 ` Russell King (Oracle)
2024-03-20 15:25 ` John Ernberg
2024-03-20 16:54 ` Russell King (Oracle)
2024-03-20 17:13 ` Florian Fainelli
2024-03-20 19:44 ` Russell King (Oracle)
2024-03-21 16:02 ` John Ernberg
2024-03-21 16:13 ` Florian Fainelli
2024-03-25 12:20 ` John Ernberg
2024-03-25 21:27 ` Florian Fainelli
2024-03-28 11:52 ` John Ernberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240306133734.4144808-1-john.ernberg@actia.se \
--to=john.ernberg@actia.se \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shenwei.wang@nxp.com \
--cc=wei.fang@nxp.com \
--cc=xiaoning.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).