From: Jakub Kicinski <kuba@kernel.org>
To: Mark Cilissen <mark@yotsuba.nl>
Cc: netdev@vger.kernel.org, Hans de Goede <hdegoede@redhat.com>,
Eric Dumazet <edumazet@google.com>,
Breno Leitao <leitao@debian.org>, Ingo Molnar <mingo@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] netpoll: support sending over raw IP interfaces
Date: Thu, 14 Mar 2024 11:34:55 -0700 [thread overview]
Message-ID: <20240314113455.152cebc9@kernel.org> (raw)
In-Reply-To: <20240313124613.51399-1-mark@yotsuba.nl>
On Wed, 13 Mar 2024 13:46:13 +0100 Mark Cilissen wrote:
> Currently, netpoll only supports interfaces with an ethernet-compatible
> link layer. Certain interfaces like SLIP do not have a link layer
> on the network interface level at all and expect raw IP packets,
> and could benefit from being supported by netpoll.
>
> This commit adds support for such interfaces by using the network device's
> `hard_header_len` field as an indication that no link layer is present.
> If that is the case we simply skip adding the ethernet header, causing
> a raw IP packet to be sent over the interface. This has been confirmed
> to add netconsole support to at least SLIP and WireGuard interfaces.
Would be great if this could come with a simple selftest under
tools/testing/selftests/net. Preferably using some simple tunnel
device, rather than wg to limit tooling dependencies ;)
next prev parent reply other threads:[~2024-03-14 18:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-13 12:46 [PATCH] netpoll: support sending over raw IP interfaces Mark Cilissen
2024-03-13 13:36 ` Ratheesh Kannoth
2024-03-13 13:53 ` Mark
2024-03-14 2:46 ` [EXTERNAL] " Ratheesh Kannoth
2024-03-18 11:43 ` [EXTERNAL] " Mark
2024-03-18 14:06 ` Ratheesh Kannoth
2024-03-21 12:33 ` Mark
2024-03-22 3:33 ` Ratheesh Kannoth
2024-03-14 12:48 ` Paolo Abeni
2024-03-14 18:34 ` Jakub Kicinski [this message]
2024-03-18 11:47 ` Mark
2024-03-19 17:10 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240314113455.152cebc9@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hdegoede@redhat.com \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark@yotsuba.nl \
--cc=mingo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).