From: Shigeru Yoshida <syoshida@redhat.com>
To: fmaurer@redhat.com
Cc: netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, leitao@debian.org,
dkirjanov@suse.de
Subject: Re: [PATCH net v2] hsr: Handle failures in module init
Date: Mon, 18 Mar 2024 14:23:34 +0900 (JST) [thread overview]
Message-ID: <20240318.142334.2245574100586239129.syoshida@redhat.com> (raw)
In-Reply-To: <3ce097c15e3f7ace98fc7fd9bcbf299f092e63d1.1710504184.git.fmaurer@redhat.com>
On Fri, 15 Mar 2024 13:04:52 +0100, Felix Maurer wrote:
> A failure during registration of the netdev notifier was not handled at
> all. A failure during netlink initialization did not unregister the netdev
> notifier.
>
> Handle failures of netdev notifier registration and netlink initialization.
> Both functions should only return negative values on failure and thereby
> lead to the hsr module not being loaded.
>
> Fixes: f421436a591d ("net/hsr: Add support for the High-availability Seamless Redundancy protocol (HSRv0)")
> Signed-off-by: Felix Maurer <fmaurer@redhat.com>
The patch LGTM. Module initialization errors are handled
correctly. Netdev notifier is correctly unregistered when netlink
initialization fails.
Reviewed-by: Shigeru Yoshida <syoshida@redhat.com>
> ---
> net/hsr/hsr_main.c | 15 +++++++++++----
> 1 file changed, 11 insertions(+), 4 deletions(-)
>
> diff --git a/net/hsr/hsr_main.c b/net/hsr/hsr_main.c
> index cb83c8feb746..9756e657bab9 100644
> --- a/net/hsr/hsr_main.c
> +++ b/net/hsr/hsr_main.c
> @@ -148,14 +148,21 @@ static struct notifier_block hsr_nb = {
>
> static int __init hsr_init(void)
> {
> - int res;
> + int err;
>
> BUILD_BUG_ON(sizeof(struct hsr_tag) != HSR_HLEN);
>
> - register_netdevice_notifier(&hsr_nb);
> - res = hsr_netlink_init();
> + err = register_netdevice_notifier(&hsr_nb);
> + if (err)
> + return err;
> +
> + err = hsr_netlink_init();
> + if (err) {
> + unregister_netdevice_notifier(&hsr_nb);
> + return err;
> + }
>
> - return res;
> + return 0;
> }
>
> static void __exit hsr_exit(void)
> --
> 2.44.0
>
>
next prev parent reply other threads:[~2024-03-18 5:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-15 12:04 [PATCH net v2] hsr: Handle failures in module init Felix Maurer
2024-03-18 5:23 ` Shigeru Yoshida [this message]
2024-03-18 9:36 ` Breno Leitao
2024-03-19 12:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240318.142334.2245574100586239129.syoshida@redhat.com \
--to=syoshida@redhat.com \
--cc=davem@davemloft.net \
--cc=dkirjanov@suse.de \
--cc=edumazet@google.com \
--cc=fmaurer@redhat.com \
--cc=kuba@kernel.org \
--cc=leitao@debian.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).