From: Simon Horman <horms@kernel.org>
To: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
Marcin Szycik <marcin.szycik@linux.intel.com>,
Michal Kubiak <michal.kubiak@intel.com>
Subject: Re: [iwl-net v1] ice: tc: do default match on all profiles
Date: Mon, 18 Mar 2024 18:55:59 +0000 [thread overview]
Message-ID: <20240318185559.GF1623@kernel.org> (raw)
In-Reply-To: <20240312105259.2450-1-michal.swiatkowski@linux.intel.com>
On Tue, Mar 12, 2024 at 11:52:59AM +0100, Michal Swiatkowski wrote:
> A simple non-tunnel rule (e.g. matching only on destination MAC) in
> hardware will be hit only if the packet isn't a tunnel. In software
> execution of the same command, the rule will match both tunnel and
> non-tunnel packets.
>
> Change the hardware behaviour to match tunnel and non-tunnel packets in
> this case. Do this by considering all profiles when adding non-tunnel rule
> (rule not added on tunnel, or not redirecting to tunnel).
>
> Example command:
> tc filter add dev pf0 ingress protocol ip flower skip_sw action mirred \
> egress redirect dev pr0
>
> It should match also tunneled packets, the same as command with skip_hw
> will do in software.
>
> Fixes: 9e300987d4a8 ("ice: VXLAN and Geneve TC support")
> Reviewed-by: Marcin Szycik <marcin.szycik@linux.intel.com>
> Reviewed-by: Michal Kubiak <michal.kubiak@intel.com>
> Signed-off-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2024-03-18 18:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-12 10:52 [iwl-net v1] ice: tc: do default match on all profiles Michal Swiatkowski
2024-03-18 18:55 ` Simon Horman [this message]
2024-03-25 6:36 ` [Intel-wired-lan] " Buvaneswaran, Sujai
2024-03-29 8:25 ` Michal Swiatkowski
2024-04-01 9:28 ` Buvaneswaran, Sujai
2024-04-05 8:43 ` Michal Swiatkowski
2024-04-10 9:57 ` Michal Swiatkowski
2024-04-10 21:40 ` Tony Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240318185559.GF1623@kernel.org \
--to=horms@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=marcin.szycik@linux.intel.com \
--cc=michal.kubiak@intel.com \
--cc=michal.swiatkowski@linux.intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).