From: Horatiu Vultur <horatiu.vultur@microchip.com>
To: Min Li <lnimi@hotmail.com>
Cc: <richardcochran@gmail.com>, <lee@kernel.org>,
<linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
Min Li <min.li.xe@renesas.com>
Subject: Re: [PATCH net-next v7 3/5] ptp: clockmatrix: dco input-to-output delay is 20 FOD cycles + 8ns
Date: Thu, 2 May 2024 08:49:46 +0200 [thread overview]
Message-ID: <20240502064946.yc6v7xadwkfldbsw@DEN-DL-M31836.microchip.com> (raw)
In-Reply-To: <LV3P220MB12024CB984967E4AC05A1E13A0192@LV3P220MB1202.NAMP220.PROD.OUTLOOK.COM>
The 05/01/2024 12:03, Min Li wrote:
Hi Min Li,
>
> From: Min Li <min.li.xe@renesas.com>
>
> Set dco input-to-output delay is 20 FOD cycles + 8ns
Can you explain why you are doing this change in the commit message?
Is this a fix or just improvement?
>
> Signed-off-by: Min Li <min.li.xe@renesas.com>
> ---
> drivers/ptp/ptp_clockmatrix.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/ptp/ptp_clockmatrix.c b/drivers/ptp/ptp_clockmatrix.c
> index d069b6e451ef..21f3a2c179f5 100644
> --- a/drivers/ptp/ptp_clockmatrix.c
> +++ b/drivers/ptp/ptp_clockmatrix.c
> @@ -2165,7 +2165,7 @@ static int configure_channel_pll(struct idtcm_channel *channel)
>
> /*
> * Compensate for the PTP DCO input-to-output delay.
> - * This delay is 18 FOD cycles.
> + * This delay is 20 FOD cycles + 8ns.
> */
> static u32 idtcm_get_dco_delay(struct idtcm_channel *channel)
> {
> @@ -2196,7 +2196,7 @@ static u32 idtcm_get_dco_delay(struct idtcm_channel *channel)
> fodFreq = (u32)div_u64(m, n);
>
> if (fodFreq >= 500000000)
> - return (u32)div_u64(18 * (u64)NSEC_PER_SEC, fodFreq);
> + return (u32)div_u64(20 * (u64)NSEC_PER_SEC, fodFreq) + 8;
>
> return 0;
> }
> --
> 2.39.2
>
>
--
/Horatiu
next prev parent reply other threads:[~2024-05-02 6:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240501160324.27514-1-lnimi@hotmail.com>
2024-05-01 16:03 ` [PATCH net-next v7 1/5] ptp: clockmatrix: support 32-bit address space Min Li
2024-05-01 16:03 ` [PATCH net-next v7 2/5] ptp: clockmatrix: set write phase timer to 0 when not in PCW mode Min Li
2024-05-01 16:03 ` [PATCH net-next v7 3/5] ptp: clockmatrix: dco input-to-output delay is 20 FOD cycles + 8ns Min Li
2024-05-02 6:49 ` Horatiu Vultur [this message]
2024-05-03 14:04 ` Min Li
2024-05-01 16:03 ` [PATCH net-next v7 4/5] ptp: clockmatrix: Fix caps.max_adj to reflect DPLL_MAX_FREQ_OFFSET[MAX_FFO] Min Li
2024-05-02 6:54 ` Horatiu Vultur
2024-05-01 16:03 ` [PATCH net-next v7 5/5] ptp: clockmatrix: move register and firmware related definition to idt8a340_reg.h Min Li
[not found] <20240318173213.28475-1-lnimi@hotmail.com>
2024-03-18 17:32 ` [PATCH net-next v7 3/5] ptp: clockmatrix: dco input-to-output delay is 20 FOD cycles + 8ns Min Li
[not found] <20240314153707.31551-1-lnimi@hotmail.com>
2024-03-14 15:37 ` Min Li
[not found] <20240104163641.15893-1-lnimi@hotmail.com>
2024-01-04 16:36 ` Min Li
[not found] <20231214152415.14785-1-lnimi@hotmail.com>
2023-12-14 15:24 ` Min Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240502064946.yc6v7xadwkfldbsw@DEN-DL-M31836.microchip.com \
--to=horatiu.vultur@microchip.com \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lnimi@hotmail.com \
--cc=min.li.xe@renesas.com \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).