From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1AD78C43381 for ; Mon, 25 Feb 2019 18:46:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E5A9B2087C for ; Mon, 25 Feb 2019 18:46:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fvWWC8t2" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728524AbfBYSqz (ORCPT ); Mon, 25 Feb 2019 13:46:55 -0500 Received: from mail-pf1-f193.google.com ([209.85.210.193]:45915 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728382AbfBYSqy (ORCPT ); Mon, 25 Feb 2019 13:46:54 -0500 Received: by mail-pf1-f193.google.com with SMTP id v21so4884933pfm.12 for ; Mon, 25 Feb 2019 10:46:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=P1s7XxJikWw23iv8hwFsiKkPjrCVS6X3t8AkbfcIBU8=; b=fvWWC8t2PznqiCUExVelfUrScxunjdsAZwxVhOHUK52j7f8xQcX7OFfxUu+brlTZ9X Lazll6bv3gEZUvaro3/3Rf4ceJE8ockxuhioGfOQCxfSwKSl+o3QLz9fLqXRSa2cP1+F EQpD3s2C0zNo9okLPN9G+X6+feEIfbtBy3Fij4D66LSWR32i1newUN7AzQ85tX2BNVC0 hbCpp6kMuFYd8YJHiF+gLwsVBWgJPiMRaAQbfCWBMiLXGkH+2nwH+kXcedGyK2whimgF cZa7J0Ziy1hn9FfgqAnoyMBfy9bD17e1/mku+jouqkYVVlXv/qhvYJHCKxvpiMkEPed0 TlmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=P1s7XxJikWw23iv8hwFsiKkPjrCVS6X3t8AkbfcIBU8=; b=Wal7iZW6Btv550c5zWkNWYjuv6p1+f4YNScF4SiMgQvswxZ4npTWeq5lQYzuGvffC+ 3UFKZaGei+FUpLESRix+hmiFbQ1i1fx3esN1ZqOoipmXMr6QFII2Ohqwr4hiwDuT25SG JAp54kykdTAdvsme+i3ERtTQENgdCLXupwqjm5r10reSppSzZlhkyL+7cqzEhTk10l6i CBZ2icnE9M4Lkf8NNzb8ha4YlMHHpsz9KIepGRYnVxsYWvh2zVAdmPt1+HSOrJ72jpxC tD7IyL3deJwlV2y4Ceor6Znyizxnhk6YVjf5UTDBjFB69wAc35I5/LWTXrktTDQA2TCt s3qw== X-Gm-Message-State: AHQUAuaqLg9M+Rc3gYqq/eDYK3QxZzOZy9+yzwx3ZaLyHCUpKfLJs2bW pxHFV31+VdBYCKFzJ8c3ex4= X-Google-Smtp-Source: AHgI3IbvBdDb/LAJgvAgkWNrDfNXQdoDNljNzATC9d3LSTZglF5PFN46YUANzUl44Wo+e6KxarfFyw== X-Received: by 2002:a63:112:: with SMTP id 18mr19544527pgb.139.1551120414027; Mon, 25 Feb 2019 10:46:54 -0800 (PST) Received: from ?IPv6:2601:282:800:fd80:e962:5547:1520:25d4? ([2601:282:800:fd80:e962:5547:1520:25d4]) by smtp.googlemail.com with ESMTPSA id a4sm19693255pga.52.2019.02.25.10.46.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 25 Feb 2019 10:46:53 -0800 (PST) Subject: Re: [PATCH net] ipv4: Add ICMPv6 support when parse route ipproto To: Sabrina Dubroca , Hangbin Liu Cc: netdev@vger.kernel.org, Roopa Prabhu , "David S . Miller" References: <20190225074700.7316-1-liuhangbin@gmail.com> <20190225111439.GA26565@bistromath.localdomain> From: David Ahern Message-ID: <212750de-2d6a-ebb9-5079-bacf234f6cf6@gmail.com> Date: Mon, 25 Feb 2019 11:46:51 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190225111439.GA26565@bistromath.localdomain> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 2/25/19 4:14 AM, Sabrina Dubroca wrote: > 2019-02-25, 15:47:00 +0800, Hangbin Liu wrote: >> @@ -14,6 +15,7 @@ int rtm_getroute_parse_ip_proto(struct nlattr *attr, u8 *ip_proto, >> case IPPROTO_TCP: >> case IPPROTO_UDP: >> case IPPROTO_ICMP: >> + case IPPROTO_ICMPV6: > > Is IPPROTO_ICMPV6 supposed to be valid in the IPv4 code path calling > this function? no. I do not see how that makes sense.