netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Void <mail@void.so>
To: David Ahern <dsahern@gmail.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	Jonathan Corbet <corbet@lwn.net>,
	Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
	Shuah Khan <shuah@kernel.org>,
	Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	Ido Schimmel <idosch@nvidia.com>
Subject: Re: [PATCH v4 net-next] net: multipath routing: configurable seed
Date: Tue, 27 Apr 2021 17:58:22 +0300	[thread overview]
Message-ID: <21a2fb1925b215cc48ab8e2f783a7de7@void.so> (raw)
In-Reply-To: <e5e46b25-065f-7c56-3c31-6b9cc130510d@gmail.com>

On 2021-04-27 17:27, David Ahern wrote:
> On 4/27/21 3:42 AM, Pavel Balaev wrote:
>> After running "scripts/checkpatch.pl" I got warnings about alignment.
>> So I run checkpatch.pl --fix and fixed alignment as a script did.
>> So warnings goes away. I don't get the rules of alignment, can you
>> tell me the right way?
> 
> I don't see any statements under Documentation/process; not sure where
> it is explicitly stated. You can get the general idea by following the
> surrounding code and then let checkpatch correct from there.
I create 3 patches and check it:

./scripts/checkpatch.pl 
0001-net-ipv4-multipath-routing-configurable-seed.patch
total: 0 errors, 0 warnings, 0 checks, 186 lines checked

0001-net-ipv4-multipath-routing-configurable-seed.patch has no obvious 
style problems and is ready for submission.
./scripts/checkpatch.pl 
0002-net-ipv6-multipath-routing-configurable-seed.patch
total: 0 errors, 0 warnings, 0 checks, 151 lines checked

0002-net-ipv6-multipath-routing-configurable-seed.patch has no obvious 
style problems and is ready for submission.
./scripts/checkpatch.pl 
0003-selftests-net-forwarding-configurable-seed-tests.patch
WARNING: added, moved or deleted file(s), does MAINTAINERS need 
updating?
#76:
new file mode 100755

total: 0 errors, 1 warnings, 394 lines checked

No alignment warnings at all.

  reply	other threads:[~2021-04-27 14:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-23 13:44 [PATCH v4 net-next] net: multipath routing: configurable seed Balaev Pavel
2021-04-27  3:21 ` David Ahern
2021-04-27  9:42   ` Pavel Balaev
2021-04-27 14:27     ` David Ahern
2021-04-27 14:58       ` Void [this message]
2021-04-29 18:52 ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=21a2fb1925b215cc48ab8e2f783a7de7@void.so \
    --to=mail@void.so \
    --cc=christophe.jaillet@wanadoo.fr \
    --cc=corbet@lwn.net \
    --cc=davem@davemloft.net \
    --cc=dsahern@gmail.com \
    --cc=idosch@nvidia.com \
    --cc=kuba@kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=shuah@kernel.org \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).