netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Kiyanovski, Arthur" <akiyano@amazon.com>
To: "Tal Gilboa" <talgi@mellanox.com>,
	"Uwe Kleine-König" <uwe@kleine-koenig.org>,
	"Saeed Mahameed" <saeedm@mellanox.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: RE: [PATCH] dimlib: make DIMLIB a hidden symbol
Date: Wed, 25 Sep 2019 07:59:33 +0000	[thread overview]
Message-ID: <228c9ba04ceb4b728c83adeb379fb564@EX13D22EUA004.ant.amazon.com> (raw)
In-Reply-To: <670cc72f-fef0-a8cf-eb03-25fdb608eea8@mellanox.com>

> -----Original Message-----
> From: Tal Gilboa <talgi@mellanox.com>
> Sent: Friday, September 20, 2019 8:02 PM
> To: Uwe Kleine-König <uwe@kleine-koenig.org>; Saeed Mahameed
> <saeedm@mellanox.com>; Kiyanovski, Arthur <akiyano@amazon.com>
> Cc: linux-kernel@vger.kernel.org; netdev@vger.kernel.org
> Subject: Re: [PATCH] dimlib: make DIMLIB a hidden symbol
> 
> On 9/20/2019 4:31 PM, Uwe Kleine-König wrote:
> > According to Tal Gilboa the only benefit from DIM comes from a driver
> > that uses it. So it doesn't make sense to make this symbol user visible,
> > instead all drivers that use it should select it (as is already the case
> > AFAICT).
> >
> > Signed-off-by: Uwe Kleine-König <uwe@kleine-koenig.org>
> > ---
> >   lib/Kconfig | 3 +--
> >   1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/lib/Kconfig b/lib/Kconfig
> > index cc04124ed8f7..9fe8a21fd183 100644
> > --- a/lib/Kconfig
> > +++ b/lib/Kconfig
> > @@ -555,8 +555,7 @@ config SIGNATURE
> >   	  Implementation is done using GnuPG MPI library
> >
> >   config DIMLIB
> > -	bool "DIM library"
> > -	default y
> > +	bool
> >   	help
> >   	  Dynamic Interrupt Moderation library.
> >   	  Implements an algorithm for dynamically change CQ moderation
> values
> >
> There's a pending series using DIM which didn't add the select clause
> [1]. Arthur, FYI. Other than that LGTM.
> 
> [1] https://www.mail-archive.com/netdev@vger.kernel.org/msg314304.html

Thanks Tal, I missed that.

  parent reply	other threads:[~2019-09-25  8:00 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-20 13:31 [PATCH] dimlib: make DIMLIB a hidden symbol Uwe Kleine-König
2019-09-20 17:02 ` Tal Gilboa
2019-09-20 17:41   ` Randy Dunlap
2019-09-20 17:58   ` Uwe Kleine-König
2019-09-25  7:59   ` Kiyanovski, Arthur [this message]
2019-09-22  3:06 ` Jakub Kicinski
2019-09-23  6:18   ` Uwe Kleine-König
2019-09-24 14:45 ` David Miller
2019-09-24 16:02   ` [PATCH v2] " Uwe Kleine-König
2019-09-26  0:18     ` Randy Dunlap
2019-09-27  7:51     ` David Miller
2019-09-30 19:34 ` [PATCH] " Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=228c9ba04ceb4b728c83adeb379fb564@EX13D22EUA004.ant.amazon.com \
    --to=akiyano@amazon.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=saeedm@mellanox.com \
    --cc=talgi@mellanox.com \
    --cc=uwe@kleine-koenig.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).