From: David Ahern <dsahern@gmail.com>
To: Eric Dumazet <edumazet@google.com>,
"David S . Miller" <davem@davemloft.net>
Cc: netdev <netdev@vger.kernel.org>,
"Eric Dumazet" <eric.dumazet@gmail.com>,
"Maciej Żenczykowski" <maze@google.com>,
"Alex Belits" <abelits@marvell.com>,
"Nitesh Narayan Lal" <nitesh@redhat.com>,
"Peter Zijlstra" <peterz@infradead.org>
Subject: Re: [PATCH net] net: accept an empty mask in /sys/class/net/*/queues/rx-*/rps_cpus
Date: Tue, 11 Aug 2020 21:18:30 -0600 [thread overview]
Message-ID: <236b4f44-70a0-834e-441b-cd50eb3c0051@gmail.com> (raw)
In-Reply-To: <5b61d241-fedb-f694-c0a1-e46b0dedab66@gmail.com>
On 8/11/20 9:16 PM, David Ahern wrote:
> On 8/11/20 7:34 PM, Eric Dumazet wrote:
>> We must accept an empty mask in store_rps_map(), or we are not able
>> to disable RPS on a queue.
>
> 0 works. Is that not sufficient?
>
To re-phrase:
echo 0 > /sys/class/net/*/queues/rx-*/rps_cpus
works to disable rps. I don't get the difference in what you are
changing here.
next prev parent reply other threads:[~2020-08-12 3:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-12 1:34 [PATCH net] net: accept an empty mask in /sys/class/net/*/queues/rx-*/rps_cpus Eric Dumazet
2020-08-12 2:25 ` Maciej Żenczykowski
2020-08-12 3:16 ` David Ahern
2020-08-12 3:18 ` David Ahern [this message]
2020-08-12 3:19 ` Maciej Żenczykowski
2020-08-12 3:22 ` David Ahern
2020-08-12 3:27 ` Eric Dumazet
[not found] ` <CANP3RGc6Gz73Gt3v9M7KYNeNd57o--=3mF6yqdRjqOViG+TG7A@mail.gmail.com>
2020-08-12 8:00 ` peterz
2020-08-12 15:19 ` Eric Dumazet
2020-08-12 12:53 ` Nitesh Narayan Lal
2020-08-12 21:25 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=236b4f44-70a0-834e-441b-cd50eb3c0051@gmail.com \
--to=dsahern@gmail.com \
--cc=abelits@marvell.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=maze@google.com \
--cc=netdev@vger.kernel.org \
--cc=nitesh@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).