From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECAC6C3A59E for ; Fri, 16 Aug 2019 15:29:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CD71D2171F for ; Fri, 16 Aug 2019 15:29:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727357AbfHPP3p (ORCPT ); Fri, 16 Aug 2019 11:29:45 -0400 Received: from www62.your-server.de ([213.133.104.62]:38210 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727345AbfHPP3p (ORCPT ); Fri, 16 Aug 2019 11:29:45 -0400 Received: from sslproxy06.your-server.de ([78.46.172.3]) by www62.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1hyeAS-0000J3-L6; Fri, 16 Aug 2019 17:29:28 +0200 Received: from [2a02:120b:2c12:c120:71a0:62dd:894c:fd0e] (helo=pc-66.home) by sslproxy06.your-server.de with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89) (envelope-from ) id 1hyeAS-000SI0-EK; Fri, 16 Aug 2019 17:29:28 +0200 Subject: Re: [PATCH bpf-next] libbpf: relicense bpf_helpers.h and bpf_endian.h To: Jesper Dangaard Brouer , Andrii Nakryiko Cc: bpf@vger.kernel.org, netdev@vger.kernel.org, andrii.nakryiko@gmail.com, kernel-team@fb.com, Michael Holzheu , "Naveen N . Rao" , "David S . Miller" , Michal Rostecki , John Fastabend , Sargun Dhillon References: <20190816054543.2215626-1-andriin@fb.com> <20190816141001.4a879101@carbon> From: Daniel Borkmann Message-ID: <23a87525-acf5-7a7e-b7b6-3c47b9760eeb@iogearbox.net> Date: Fri, 16 Aug 2019 17:29:27 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <20190816141001.4a879101@carbon> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Authenticated-Sender: daniel@iogearbox.net X-Virus-Scanned: Clear (ClamAV 0.100.3/25543/Fri Aug 16 10:23:13 2019) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 8/16/19 2:10 PM, Jesper Dangaard Brouer wrote: > On Thu, 15 Aug 2019 22:45:43 -0700 > Andrii Nakryiko wrote: > >> bpf_helpers.h and bpf_endian.h contain useful macros and BPF helper >> definitions essential to almost every BPF program. Which makes them >> useful not just for selftests. To be able to expose them as part of >> libbpf, though, we need them to be dual-licensed as LGPL-2.1 OR >> BSD-2-Clause. This patch updates licensing of those two files. > > I've already ACKed this, and is fine with (LGPL-2.1 OR BSD-2-Clause). > > I just want to understand, why "BSD-2-Clause" and not "Apache-2.0" ? > > The original argument was that this needed to be compatible with > "Apache-2.0", then why not simply add this in the "OR" ? It's use is discouraged in the kernel tree, see also LICENSES/dual/Apache-2.0 (below) and statement wrt compatibility from https://www.apache.org/licenses/GPL-compatibility.html: Valid-License-Identifier: Apache-2.0 SPDX-URL: https://spdx.org/licenses/Apache-2.0.html Usage-Guide: Do NOT use. The Apache-2.0 is not GPL2 compatible. [...] >> Acked-by: Alexei Starovoitov >> Acked-by: Hechao Li >> Acked-by: Martin KaFai Lau >> Acked-by: Andrey Ignatov >> Acked-by: Yonghong Song >> Acked-by: Lawrence Brakmo >> Acked-by: Adam Barth >> Acked-by: Roman Gushchin >> Acked-by: Josef Bacik >> Acked-by: Joe Stringer >> Acked-by: Daniel Borkmann >> Acked-by: Joel Fernandes (Google) >> Acked-by: David Ahern >> Acked-by: Jesper Dangaard Brouer > > Confirming I acked this. > >> Acked-by: Ilya Leoshkevich >> Acked-by: Lorenz Bauer >> Acked-by: Adrian Ratiu >> Acked-by: Nikita V. Shirokov >> Acked-by: Willem de Bruijn >> Acked-by: Petar Penkov >> Acked-by: Teng Qin >> Cc: Michael Holzheu >> Cc: Naveen N. Rao >> Cc: David S. Miller >> Cc: Michal Rostecki >> Cc: John Fastabend >> Cc: Sargun Dhillon >> Signed-off-by: Andrii Nakryiko >> --- >> tools/testing/selftests/bpf/bpf_endian.h | 2 +- >> tools/testing/selftests/bpf/bpf_helpers.h | 2 +- >> 2 files changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/tools/testing/selftests/bpf/bpf_endian.h b/tools/testing/selftests/bpf/bpf_endian.h >> index 05f036df8a4c..ff3593b0ae03 100644 >> --- a/tools/testing/selftests/bpf/bpf_endian.h >> +++ b/tools/testing/selftests/bpf/bpf_endian.h >> @@ -1,4 +1,4 @@ >> -/* SPDX-License-Identifier: GPL-2.0 */ >> +/* SPDX-License-Identifier: (LGPL-2.1 OR BSD-2-Clause) */ >> #ifndef __BPF_ENDIAN__ >> #define __BPF_ENDIAN__ >> >> diff --git a/tools/testing/selftests/bpf/bpf_helpers.h b/tools/testing/selftests/bpf/bpf_helpers.h >> index 8b503ea142f0..6c4930bc6e2e 100644 >> --- a/tools/testing/selftests/bpf/bpf_helpers.h >> +++ b/tools/testing/selftests/bpf/bpf_helpers.h >> @@ -1,4 +1,4 @@ >> -/* SPDX-License-Identifier: GPL-2.0 */ >> +/* SPDX-License-Identifier: (LGPL-2.1 OR BSD-2-Clause) */ >> #ifndef __BPF_HELPERS_H >> #define __BPF_HELPERS_H >> > > >