netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Дмитрий Якунин" <zeil@yandex-team.ru>
To: David Ahern <dsahern@gmail.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Cc: "cgroups@vger.kernel.org" <cgroups@vger.kernel.org>
Subject: Re: [PATCH iproute2-next v2 1/3] ss: introduce cgroup2 cache and helper functions
Date: Wed, 13 May 2020 10:27:42 +0300	[thread overview]
Message-ID: <25511589354341@mail.yandex-team.ru> (raw)
In-Reply-To: <42814b4f-dc95-d246-47a4-2b8c46dd607e@gmail.com>



13.05.2020, 05:03, "David Ahern" <dsahern@gmail.com>:
> On 5/9/20 10:52 AM, Dmitry Yakunin wrote:
>>  This patch prepares infrastructure for matching sockets by cgroups.
>>  Two helper functions are added for transformation between cgroup v2 ID
>>  and pathname. Cgroup v2 cache is implemented as hash table indexed by ID.
>>  This cache is needed for faster lookups of socket cgroup.
>>
>>  v2:
>>    - style fixes (David Ahern)
>
> you missed my other comment about this set. Running this new command on
> a kernel without support should give the user a better error message
> than a string of Invalid arguments:
>
> $ uname -r
> 5.3.0-51-generic
>
> $ ss -a cgroup /sys/fs/cgroup/unified
> RTNETLINK answers: Invalid argument
> RTNETLINK answers: Invalid argument
> RTNETLINK answers: Invalid argument
> RTNETLINK answers: Invalid argument
> RTNETLINK answers: Invalid argument
> RTNETLINK answers: Invalid argument
> RTNETLINK answers: Invalid argument
> RTNETLINK answers: Invalid argument
> RTNETLINK answers: Invalid argument

No, i didn't miss your comment. This patchset was extended with the third patch which includes bytecode filter checking.

  reply	other threads:[~2020-05-13  7:27 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-09 16:52 [PATCH iproute2-next v2 1/3] ss: introduce cgroup2 cache and helper functions Dmitry Yakunin
2020-05-09 16:52 ` [PATCH iproute2-next v2 2/3] ss: add support for cgroup v2 information and filtering Dmitry Yakunin
2020-05-09 16:52 ` [PATCH iproute2-next v2 3/3] ss: add checks for bc filter support Dmitry Yakunin
2020-05-13  2:03 ` [PATCH iproute2-next v2 1/3] ss: introduce cgroup2 cache and helper functions David Ahern
2020-05-13  7:27   ` Дмитрий Якунин [this message]
2020-05-14  3:28     ` David Ahern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=25511589354341@mail.yandex-team.ru \
    --to=zeil@yandex-team.ru \
    --cc=cgroups@vger.kernel.org \
    --cc=dsahern@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).