From: Markus Elfring <Markus.Elfring@web.de>
To: Qiushi Wu <wu000273@umn.edu>,
linux-afs@lists.infradead.org, netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, David Howells <dhowells@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Kangjie Lu <kjlu@umn.edu>
Subject: Re: [PATCH] rxrpc: Fix a memory leak in rxkad_verify_response()
Date: Fri, 22 May 2020 08:30:41 +0200 [thread overview]
Message-ID: <262bd413-9be4-3abe-9565-ac37a2e2e719@web.de> (raw)
> In function rxkad_verify_response(), pointer "ticket" is not released,
> when function rxkad_decrypt_ticket() returns an error, causing a
> memory leak bug.
I suggest to improve also this change description.
How do you think about a wording variant like the following?
A ticket was not released after a call of the function “platform_get_irq” failed.
Thus replace the jump target “temporary_error_free_resp”
by “temporary_error_free_ticket”.
Regards,
Markus
next reply other threads:[~2020-05-22 6:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-22 6:30 Markus Elfring [this message]
2020-05-22 6:36 ` [PATCH] rxrpc: Fix a memory leak in rxkad_verify_response() Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=262bd413-9be4-3abe-9565-ac37a2e2e719@web.de \
--to=markus.elfring@web.de \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=kjlu@umn.edu \
--cc=kuba@kernel.org \
--cc=linux-afs@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=wu000273@umn.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).