From: Roi Dayan <roid@nvidia.com>
To: Eelco Chaudron <echaudro@redhat.com>
Cc: patchwork-bot+netdevbpf@kernel.org,
Toms Atteka <cpp.code.lv@gmail.com>,
dev@openvswitch.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, kuba@kernel.org,
davem@davemloft.net
Subject: Re: [ovs-dev] [PATCH net-next v8] net: openvswitch: IPv6: Add IPv6 extension header support
Date: Mon, 7 Mar 2022 10:49:31 +0200 [thread overview]
Message-ID: <26b924fb-ed26-bb3f-8c6b-48edac825f73@nvidia.com> (raw)
In-Reply-To: <57996C97-5845-425B-9B13-7F33EE05D704@redhat.com>
On 2022-03-02 3:59 PM, Eelco Chaudron wrote:
>
>
> On 2 Mar 2022, at 11:50, Roi Dayan wrote:
>
>> On 2022-03-02 12:03 PM, Roi Dayan wrote:
>>>
>>>
>>> On 2022-02-25 12:40 PM, patchwork-bot+netdevbpf@kernel.org wrote:
>>>> Hello:
>>>>
>>>> This patch was applied to netdev/net-next.git (master)
>>>> by David S. Miller <davem@davemloft.net>:
>>>>
>>>> On Wed, 23 Feb 2022 16:54:09 -0800 you wrote:
>>>>> This change adds a new OpenFlow field OFPXMT_OFB_IPV6_EXTHDR and
>>>>> packets can be filtered using ipv6_ext flag.
>>>>>
>>>>> Signed-off-by: Toms Atteka <cpp.code.lv@gmail.com>
>>>>> Acked-by: Pravin B Shelar <pshelar@ovn.org>
>>>>> ---
>>>>> include/uapi/linux/openvswitch.h | 6 ++
>>>>> net/openvswitch/flow.c | 140 +++++++++++++++++++++++++++++++
>>>>> net/openvswitch/flow.h | 14 ++++
>>>>> net/openvswitch/flow_netlink.c | 26 +++++-
>>>>> 4 files changed, 184 insertions(+), 2 deletions(-)
>>>>
>>>> Here is the summary with links:
>>>> - [net-next,v8] net: openvswitch: IPv6: Add IPv6 extension header support
>>>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.kernel.org%2Fnetdev%2Fnet-next%2Fc%2F28a3f0601727&data=04%7C01%7Croid%40nvidia.com%7C41e35b6733e34dcf628708d9fc54dc9b%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C637818263683241778%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=iaysgYLANYFQo87ELcK9KMesF6u7pWF3cGAHiKB%2FM1E%3D&reserved=0
>>>>
>>>> You are awesome, thank you!
>>>
>>> Hi,
>>>
>>> After the merge of this patch I fail to do ipv6 traffic in ovs.
>>> Am I missing something?
>>>
>>> ovs-vswitchd.log has this msg
>>>
>>> 2022-03-02T09:52:26.604Z|00013|odp_util(handler1)|WARN|attribute packet_type has length 2 but should have length 4
>>>
>>> Thanks,
>>> Roi
>>
>>
>> I think there is a missing userspace fix. didnt verify yet.
>> but in ovs userspace odp-netlink.h created from datapath/linux/compat/include/linux/openvswitch.h
>> and that file is not synced the change here.
>> So the new enum OVS_KEY_ATTR_IPV6_EXTHDRS is missing and also struct
>> ovs_key_ipv6_exthdrs which is needed in lib/udp-util.c
>> in struct ovs_flow_key_attr_lens to add expected len for
>> OVS_KEY_ATTR_IPV6_EXTHDR.
>
> I guess if this is creating backward compatibility issues, this patch should be reverted/fixed. As a kmod upgrade should not break existing deployments.
>
it looks like it does. we can't work with ovs without reverting this.
can we continue with reverting this commit please?
next prev parent reply other threads:[~2022-03-07 8:49 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-24 0:54 [PATCH net-next v8] net: openvswitch: IPv6: Add IPv6 extension header support Toms Atteka
2022-02-25 10:40 ` patchwork-bot+netdevbpf
2022-03-02 10:03 ` [ovs-dev] " Roi Dayan
2022-03-02 10:50 ` Roi Dayan
2022-03-02 13:59 ` Eelco Chaudron
2022-03-07 8:49 ` Roi Dayan [this message]
2022-03-07 20:26 ` Jakub Kicinski
2022-03-07 22:14 ` Ilya Maximets
2022-03-07 22:46 ` Jakub Kicinski
2022-03-08 0:04 ` Ilya Maximets
2022-03-08 5:45 ` Jakub Kicinski
2022-03-08 8:21 ` Johannes Berg
2022-03-08 14:12 ` Ilya Maximets
2022-03-08 14:39 ` Roi Dayan
2022-03-08 18:25 ` Ilya Maximets
2022-03-08 20:17 ` Jakub Kicinski
2022-03-08 16:17 ` Jakub Kicinski
2022-03-08 19:33 ` Ilya Maximets
2022-03-08 20:16 ` Jakub Kicinski
2022-03-09 7:49 ` Roi Dayan
2022-03-09 13:43 ` Ilya Maximets
2022-03-09 16:17 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26b924fb-ed26-bb3f-8c6b-48edac825f73@nvidia.com \
--to=roid@nvidia.com \
--cc=cpp.code.lv@gmail.com \
--cc=davem@davemloft.net \
--cc=dev@openvswitch.org \
--cc=echaudro@redhat.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=patchwork-bot+netdevbpf@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).