From: "luobin (L)" <luobin9@huawei.com>
To: David Miller <davem@davemloft.net>
Cc: <linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
<yin.yinshi@huawei.com>, <cloud.wangxiaoyun@huawei.com>,
<chiqijun@huawei.com>, <zengweiliang.zengweiliang@huawei.com>
Subject: Re: [PATCH net] hinic: fix wrong return value of mac-set cmd
Date: Thu, 24 Sep 2020 09:26:35 +0800 [thread overview]
Message-ID: <2794a80f-1e69-3050-5b8b-4fff75f3a69a@huawei.com> (raw)
In-Reply-To: <20200923.174352.634025554486458032.davem@davemloft.net>
On 2020/9/24 8:43, David Miller wrote:
> From: Luo bin <luobin9@huawei.com>
> Date: Tue, 22 Sep 2020 19:26:43 +0800
>
>> It should also be regarded as an error when hw return status=4 for PF's
>> setting mac cmd. Only if PF return status=4 to VF should this cmd be
>> taken special treatment.
>>
>> Signed-off-by: Luo bin <luobin9@huawei.com>
>
> Bug fixes require a proper Fixes: tag.
>
> Please resubmit with the corrected, thank you.
> .
>
Will fix. Thanks!
next prev parent reply other threads:[~2020-09-24 1:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-22 11:26 [PATCH net] hinic: fix wrong return value of mac-set cmd Luo bin
2020-09-24 0:43 ` David Miller
2020-09-24 1:26 ` luobin (L) [this message]
2020-09-24 1:31 Luo bin
2020-09-25 3:02 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2794a80f-1e69-3050-5b8b-4fff75f3a69a@huawei.com \
--to=luobin9@huawei.com \
--cc=chiqijun@huawei.com \
--cc=cloud.wangxiaoyun@huawei.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yin.yinshi@huawei.com \
--cc=zengweiliang.zengweiliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).