From: Daniel Borkmann <daniel@iogearbox.net>
To: Jakub Kicinski <jakub.kicinski@netronome.com>,
Joe Perches <joe@perches.com>
Cc: syzbot <syzbot+8218a8a0ff60c19b8eae@syzkaller.appspotmail.com>,
ast@kernel.org, christian@brauner.io, davem@davemloft.net,
dsahern@gmail.com, hawk@kernel.org, idosch@mellanox.com,
john.fastabend@gmail.com, kafai@fb.com, ktkhai@virtuozzo.com,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
petrm@mellanox.com, roopa@cumulusnetworks.com,
songliubraving@fb.com, syzkaller-bugs@googlegroups.com,
xdp-newbies@vger.kernel.org, yhs@fb.com
Subject: Re: INFO: task hung in rtnetlink_rcv_msg
Date: Sat, 23 Feb 2019 01:47:00 +0100 [thread overview]
Message-ID: <279c5bae-0b18-b03a-2858-4749e18afa26@iogearbox.net> (raw)
In-Reply-To: <20190222134511.13eb7a82@cakuba.netronome.com>
On 02/22/2019 10:45 PM, Jakub Kicinski wrote:
> On Fri, 22 Feb 2019 12:14:57 -0800, Joe Perches wrote:
>> On Fri, 2019-02-22 at 12:01 -0800, Jakub Kicinski wrote:
>>> Hi!
>>>
>>> Seems like something funny is going on with get_maintainer.pl since XDP
>>> entry got added. We seem to have been CCed on:
>>
>> I suggest removing the MAINTAINERS line with
>>
>> K: xdp
>>
>> as xdp is a pretty generic file/patch content
>> regex match for the K: type
>>
>> $ git grep --name-only xdp | wc -l
>> 236
>>
>> Rather more files than desired.
>>
>> The N: match is dubious too.
>>
>> It's generally better to have specific lists of
>> maintained file patterns rather than using the
>> K: and N: pattern matches.
>>
>> ---
>> MAINTAINERS | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index d7ad97b235ec..aa703e2cb882 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -16970,7 +16970,6 @@ F: include/net/xdp.h
>> F: kernel/bpf/devmap.c
>> F: kernel/bpf/cpumap.c
>> F: include/trace/events/xdp.h
>> -K: xdp
>> N: xdp
>>
>> XDP SOCKETS (AF_XDP)
>
> Thanks for the explanation, at least now I know why it happens! :)
> I'll leave it to Daniel to decide if we really need it removed,
> so far the false positives weren't overwhelming, just surprising.
No strong opinion. I've seen this K+N pattern in a number of places
in the maintainers file. I'm fine either way if it gets too noisy. :)
next prev parent reply other threads:[~2019-02-23 0:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-22 17:00 INFO: task hung in rtnetlink_rcv_msg syzbot
2019-02-22 20:01 ` Jakub Kicinski
2019-02-22 20:14 ` Joe Perches
2019-02-22 21:45 ` Jakub Kicinski
2019-02-23 0:47 ` Daniel Borkmann [this message]
2019-02-25 8:39 ` Jesper Dangaard Brouer
2019-02-25 16:55 ` Joe Perches
2019-02-25 19:26 ` Jesper Dangaard Brouer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=279c5bae-0b18-b03a-2858-4749e18afa26@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=ast@kernel.org \
--cc=christian@brauner.io \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=hawk@kernel.org \
--cc=idosch@mellanox.com \
--cc=jakub.kicinski@netronome.com \
--cc=joe@perches.com \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=ktkhai@virtuozzo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=petrm@mellanox.com \
--cc=roopa@cumulusnetworks.com \
--cc=songliubraving@fb.com \
--cc=syzbot+8218a8a0ff60c19b8eae@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=xdp-newbies@vger.kernel.org \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).