From: Karsten Graul <kgraul@linux.ibm.com>
To: Cong Wang <xiyou.wangcong@gmail.com>, netdev@vger.kernel.org
Cc: linux-s390@vger.kernel.org, Cong Wang <cong.wang@bytedance.com>,
syzbot+b54a1ce86ba4a623b7f0@syzkaller.appspotmail.com,
John Fastabend <john.fastabend@gmail.com>
Subject: Re: [Patch net] smc: disallow TCP_ULP in smc_setsockopt()
Date: Tue, 13 Apr 2021 09:48:47 +0200 [thread overview]
Message-ID: <27d7157d-042c-efb8-2f89-437af321c3df@linux.ibm.com> (raw)
In-Reply-To: <20210410181732.25995-1-xiyou.wangcong@gmail.com>
On 10/04/2021 20:17, Cong Wang wrote:
> From: Cong Wang <cong.wang@bytedance.com>
>
> syzbot is able to setup kTLS on an SMC socket, which coincidentally
> uses sk_user_data too, later, kTLS treats it as psock so triggers a
> refcnt warning. The cause is that smc_setsockopt() simply calls
> TCP setsockopt(). I do not think it makes sense to setup kTLS on
> top of SMC, so we can just disallow this.
>
> Reported-and-tested-by: syzbot+b54a1ce86ba4a623b7f0@syzkaller.appspotmail.com
> Cc: John Fastabend <john.fastabend@gmail.com>
> Cc: Karsten Graul <kgraul@linux.ibm.com>
> Signed-off-by: Cong Wang <cong.wang@bytedance.com>
> ---
Signed-off-by: Karsten Graul <kgraul@linux.ibm.com>
prev parent reply other threads:[~2021-04-13 7:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-10 18:17 [Patch net] smc: disallow TCP_ULP in smc_setsockopt() Cong Wang
2021-04-12 6:52 ` Karsten Graul
2021-04-12 19:09 ` Cong Wang
2021-04-13 7:48 ` Karsten Graul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=27d7157d-042c-efb8-2f89-437af321c3df@linux.ibm.com \
--to=kgraul@linux.ibm.com \
--cc=cong.wang@bytedance.com \
--cc=john.fastabend@gmail.com \
--cc=linux-s390@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=syzbot+b54a1ce86ba4a623b7f0@syzkaller.appspotmail.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).