From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3847FC43381 for ; Tue, 19 Feb 2019 21:31:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0FC022147C for ; Tue, 19 Feb 2019 21:31:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729130AbfBSVbw (ORCPT ); Tue, 19 Feb 2019 16:31:52 -0500 Received: from www62.your-server.de ([213.133.104.62]:34696 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726239AbfBSVbw (ORCPT ); Tue, 19 Feb 2019 16:31:52 -0500 Received: from [78.46.172.2] (helo=sslproxy05.your-server.de) by www62.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1gwCTa-0000F9-BG; Tue, 19 Feb 2019 21:58:50 +0100 Received: from [178.197.248.36] (helo=linux.home) by sslproxy05.your-server.de with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89) (envelope-from ) id 1gwCTa-000PEh-45; Tue, 19 Feb 2019 21:58:50 +0100 Subject: Re: [PATCH bpf-next] bpf: check that BPF programs run with preemption disabled From: Daniel Borkmann To: Alexei Starovoitov , davem@davemloft.net Cc: peterz@infradead.org, jannh@google.com, paulmck@linux.ibm.com, will.deacon@arm.com, mingo@redhat.com, netdev@vger.kernel.org, kernel-team@fb.com References: <20190129012152.251061-1-ast@kernel.org> <799a8afa-fe19-21ad-e73e-b24199dd55c8@iogearbox.net> Message-ID: <28b8b7dc-6bc5-2982-3e57-a121dbe30873@iogearbox.net> Date: Tue, 19 Feb 2019 21:58:48 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <799a8afa-fe19-21ad-e73e-b24199dd55c8@iogearbox.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Authenticated-Sender: daniel@iogearbox.net X-Virus-Scanned: Clear (ClamAV 0.100.2/25365/Tue Feb 19 11:36:48 2019) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 01/31/2019 11:29 PM, Daniel Borkmann wrote: > On 01/29/2019 02:21 AM, Alexei Starovoitov wrote: >> From: Peter Zijlstra >> >> Introduce cant_sleep() macro for annotation of functions that cannot sleep. >> >> Use it in BPF_PROG_RUN to catch execution of BPF programs >> in preemptable context. >> >> Suggested-by: Jann Horn >> Signed-off-by: Peter Zijlstra (Intel) >> Signed-off-by: Alexei Starovoitov > > (Just fyi, will let this sit in patchwork till the preemption fixes have been > merged back from bpf into bpf-next as otherwise people will yell that they > hit this frequently.) Pushed out now, thanks!