From: Marcel Holtmann <marcel@holtmann.org>
To: Kai Ye <yekai13@huawei.com>
Cc: Johan Hedberg <johan.hedberg@gmail.com>,
Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
"open list:NETWORKING [GENERAL]" <netdev@vger.kernel.org>,
linux-bluetooth <linux-bluetooth@vger.kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 00/12] net/Bluetooth: correct the use of print format
Date: Wed, 2 Jun 2021 22:18:01 +0200 [thread overview]
Message-ID: <29FB1C65-7FA6-4110-B953-5281C0587CAF@holtmann.org> (raw)
In-Reply-To: <1621576788-48092-1-git-send-email-yekai13@huawei.com>
Hi Kai,
> According to Documentation/core-api/printk-formats.rst,
> Use the correct print format.
> 1. Printing an unsigned int value should use %u instead of %d.
> 2. Printing an unsigned long value should use %lu instead of %ld.
> Otherwise printk() might end up displaying negative numbers.
>
> changes v1 -> v2:
> fix some style problems
>
> Kai Ye (12):
> net/Bluetooth/bnep - use the correct print format
> net/Bluetooth/cmtp - use the correct print format
> net/Bluetooth/hidp - use the correct print format
> net/Bluetooth/rfcomm - use the correct print format
> net/Bluetooth/6lowpan - use the correct print format
> net/Bluetooth/a2mp - use the correct print format
> net/Bluetooth/amp - use the correct print format
> net/Bluetooth/hci - use the correct print format
> net/Bluetooth/mgmt - use the correct print format
> net/Bluetooth/msft - use the correct print format
> net/Bluetooth/sco - use the correct print format
> net/Bluetooth/smp - use the correct print format
please fix the commit message to apply with expected style. Fixing up 12 patches manually is not something I am going to do.
Regards
Marcel
prev parent reply other threads:[~2021-06-02 20:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-21 5:59 [PATCH v2 00/12] net/Bluetooth: correct the use of print format Kai Ye
2021-05-21 5:59 ` [PATCH v2 01/12] net/Bluetooth/bnep - use the correct " Kai Ye
2021-05-21 5:59 ` [PATCH v2 02/12] net/Bluetooth/cmtp " Kai Ye
2021-05-21 5:59 ` [PATCH v2 03/12] net/Bluetooth/hidp " Kai Ye
2021-05-21 5:59 ` [PATCH v2 04/12] net/Bluetooth/rfcomm " Kai Ye
2021-05-21 5:59 ` [PATCH v2 05/12] net/Bluetooth/6lowpan " Kai Ye
2021-05-21 5:59 ` [PATCH v2 06/12] net/Bluetooth/a2mp " Kai Ye
2021-05-21 5:59 ` [PATCH v2 07/12] net/Bluetooth/amp " Kai Ye
2021-05-21 5:59 ` [PATCH v2 08/12] net/Bluetooth/hci " Kai Ye
2021-05-21 5:59 ` [PATCH v2 09/12] net/Bluetooth/mgmt " Kai Ye
2021-05-21 5:59 ` [PATCH v2 10/12] net/Bluetooth/msft " Kai Ye
2021-05-21 5:59 ` [PATCH v2 11/12] net/Bluetooth/sco " Kai Ye
2021-05-21 5:59 ` [PATCH v2 12/12] net/Bluetooth/smp " Kai Ye
2021-06-02 20:18 ` Marcel Holtmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29FB1C65-7FA6-4110-B953-5281C0587CAF@holtmann.org \
--to=marcel@holtmann.org \
--cc=davem@davemloft.net \
--cc=johan.hedberg@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=yekai13@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).