netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: 梁礼学 <lianglixue@greatwall.com.cn>
To: Paul Menzel <pmenzel@molgen.mpg.de>
Cc: Jesse Brandeburg <jesse.brandeburg@intel.com>,
	anthony.l.nguyen@intel.com, Jakub Kicinski <kuba@kernel.org>,
	intel-wired-lan@lists.osuosl.org, Netdev <netdev@vger.kernel.org>
Subject: Re: [Intel-wired-lan] [PATCH v2 2/2] igb_main: Assign random MAC address instead of fail in case of invalid one
Date: Fri, 13 May 2022 11:47:56 +0800	[thread overview]
Message-ID: <2F78D699-8D54-4E3B-9D1E-DD869715D67F@greatwall.com.cn> (raw)
In-Reply-To: <d50b23b1-38b5-2522-cbf4-c360c0ed05cd@molgen.mpg.de>

Dear Paul,

Thank you so much for taking so much time to provide guidance,
I've fixed the other two issues, but the "Reported by" tag issue I don’t quite understand.

> 2022年5月12日 21:55，Paul Menzel <pmenzel@molgen.mpg.de> 写道：
> 
> Dear Lixue,
> 
> 
> Thank you for sending version 2. Some more minor nits.
> 
> Am 12.05.22 um 11:39 schrieb lixue liang:
>> In some cases, when the user uses igb_set_eeprom to modify the MAC
>> address to be invalid, the igb driver will fail to load. If there is no
>> network card device, the user must modify it to a valid MAC address by
>> other means.
>> Since the MAC address can be modified ,then add a random valid MAC address
>> to replace the invalid MAC address in the driver can be workable, it can
>> continue to finish the loading ,and output the relevant log reminder.
> 
> Please add the space after the comma.
> 
>> Reported-by: kernel test robot <lkp@intel.com>
> 
> This line is confusing. Maybe add that to the version change-log below the `---`.
> 

I add it in the form of cmmit message. I understand that you mean to add 
"Reported by" under '---‘, but I don't know how to add it. Please give me 
further guidance. I'm so sorry to trouble you.Sincerely waiting for your response.

Thank you!


  parent reply	other threads:[~2022-05-13  3:48 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-12  9:39 [PATCH v2 2/2] igb_main: Assign random MAC address instead of fail in case of invalid one lixue liang
2022-05-12 13:55 ` [Intel-wired-lan] " Paul Menzel
2022-05-13  3:25   ` 梁礼学
2022-05-13  3:47   ` 梁礼学 [this message]
2022-05-13  5:00   ` lixue liang
2022-05-30  3:19   ` [PATCH v3 3/3] " Lixue Liang
2022-05-30  7:47     ` Paul Menzel
2022-05-30 10:58   ` [PATCH v3] " Lixue Liang
2022-05-31 20:36     ` Tony Nguyen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2F78D699-8D54-4E3B-9D1E-DD869715D67F@greatwall.com.cn \
    --to=lianglixue@greatwall.com.cn \
    --cc=anthony.l.nguyen@intel.com \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=jesse.brandeburg@intel.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pmenzel@molgen.mpg.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).