From: Daniel Borkmann <daniel@iogearbox.net>
To: Jesper Dangaard Brouer <brouer@redhat.com>,
Hangbin Liu <liuhangbin@gmail.com>
Cc: bpf@vger.kernel.org, netdev@vger.kernel.org, andrii.nakryiko@gmail.com
Subject: Re: [PATCH bpf-next] bpf: fix missing * in bpf.h
Date: Wed, 24 Feb 2021 16:55:02 +0100 [thread overview]
Message-ID: <2b917326-3a63-035e-39e9-f63fe3315432@iogearbox.net> (raw)
In-Reply-To: <20210223154327.6011b5ee@carbon>
On 2/23/21 3:43 PM, Jesper Dangaard Brouer wrote:
> On Tue, 23 Feb 2021 20:45:54 +0800
> Hangbin Liu <liuhangbin@gmail.com> wrote:
>
>> Commit 34b2021cc616 ("bpf: Add BPF-helper for MTU checking") lost a *
>> in bpf.h. This will make bpf_helpers_doc.py stop building
>> bpf_helper_defs.h immediately after bpf_check_mtu, which will affect
>> future add functions.
>>
>> Fixes: 34b2021cc616 ("bpf: Add BPF-helper for MTU checking")
>> Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
>> ---
>> include/uapi/linux/bpf.h | 2 +-
>> tools/include/uapi/linux/bpf.h | 2 +-
>> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> Thanks for fixing that!
>
> Acked-by: Jesper Dangaard Brouer <brouer@redhat.com>
Thanks guys, applied!
> I though I had already fix that, but I must have missed or reintroduced
> this, when I rolling back broken ideas in V13.
>
> I usually run this command to check the man-page (before submitting):
>
> ./scripts/bpf_helpers_doc.py | rst2man | man -l -
[+ Andrii] maybe this could be included to run as part of CI to catch such
things in advance?
>> diff --git a/include/uapi/linux/bpf.h b/include/uapi/linux/bpf.h
>> index 4c24daa43bac..46248f8e024b 100644
>> --- a/include/uapi/linux/bpf.h
>> +++ b/include/uapi/linux/bpf.h
>> @@ -3850,7 +3850,7 @@ union bpf_attr {
>> *
>> * long bpf_check_mtu(void *ctx, u32 ifindex, u32 *mtu_len, s32 len_diff, u64 flags)
>> * Description
>> -
>> + *
>> * Check ctx packet size against exceeding MTU of net device (based
>> * on *ifindex*). This helper will likely be used in combination
>> * with helpers that adjust/change the packet size.
>> diff --git a/tools/include/uapi/linux/bpf.h b/tools/include/uapi/linux/bpf.h
>> index 4c24daa43bac..46248f8e024b 100644
>> --- a/tools/include/uapi/linux/bpf.h
>> +++ b/tools/include/uapi/linux/bpf.h
>> @@ -3850,7 +3850,7 @@ union bpf_attr {
>> *
>> * long bpf_check_mtu(void *ctx, u32 ifindex, u32 *mtu_len, s32 len_diff, u64 flags)
>> * Description
>> -
>> + *
>> * Check ctx packet size against exceeding MTU of net device (based
>> * on *ifindex*). This helper will likely be used in combination
>> * with helpers that adjust/change the packet size.
>
>
>
next prev parent reply other threads:[~2021-02-24 16:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-23 12:45 [PATCH bpf-next] bpf: fix missing * in bpf.h Hangbin Liu
2021-02-23 13:14 ` [PATCHv2 bpf-next] bpf: remove blank line in bpf helper description Hangbin Liu
2021-02-24 9:19 ` Jesper Dangaard Brouer
2021-02-24 16:30 ` patchwork-bot+netdevbpf
2021-02-23 14:43 ` [PATCH bpf-next] bpf: fix missing * in bpf.h Jesper Dangaard Brouer
2021-02-24 15:55 ` Daniel Borkmann [this message]
2021-02-24 18:59 ` Andrii Nakryiko
2021-02-26 16:50 ` Quentin Monnet
2021-02-26 19:59 ` Andrii Nakryiko
2021-03-02 1:31 ` Joe Stringer
2021-02-24 16:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2b917326-3a63-035e-39e9-f63fe3315432@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=andrii.nakryiko@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=brouer@redhat.com \
--cc=liuhangbin@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).