From: Dan Murphy <dmurphy@ti.com>
To: Heiner Kallweit <hkallweit1@gmail.com>, <davem@davemloft.net>,
<andrew@lunn.ch>, <f.fainelli@gmail.com>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next 2/2] net: phy: dp83td510: Add support for the DP83TD510 Ethernet PHY
Date: Thu, 8 Oct 2020 12:00:49 -0500 [thread overview]
Message-ID: <2baf2f6a-bad1-d008-fa11-3389c6b38f5b@ti.com> (raw)
In-Reply-To: <62bbff66-c2f0-df0c-82c2-7bd8b9d63220@gmail.com>
Heiner
On 10/8/20 11:51 AM, Heiner Kallweit wrote:
> On 08.10.2020 18:23, Dan Murphy wrote:
>> The DP83TD510E is an ultra-low power Ethernet physical layer transceiver
>> that supports 10M single pair cable.
>>
>> The device supports both 2.4-V p2p and 1-V p2p output voltage as defined
>> by IEEE 802.3cg 10Base-T1L specfications. These modes can be forced via
>> the device tree or the device is defaulted to auto negotiation to
>> determine the proper p2p voltage.
>>
>> Signed-off-by: Dan Murphy <dmurphy@ti.com>
>> ---
>> drivers/net/phy/Kconfig | 6 +
<snip>
>> +static struct phy_driver dp83td510_driver[] = {
>> + {
>> + PHY_ID_MATCH_MODEL(DP83TD510E_PHY_ID),
>> + .name = "TI DP83TD510E",
>> + .probe = dp83td510_probe,
>> + .config_init = dp83td510_config_init,
>> + .soft_reset = dp83td510_phy_reset,
>> + .features = PHY_BASIC_FEATURES,
> Per default phylib uses genphy_read_abilities() to auto-detect
> the features. Doesn't your PHY support the needed clause 22
> standard registers? Or are they incorrectly populated?
>
> Maybe better than setting PHY_BASIC_FEATURES and then removing
> unsuported features in dp83td510_config_init() would be to
> implement phy_driver callback get_features. Then you can set
> the supported fatures directly.
>
Thanks for the review. I will have to look at this maybe the call back
will be better.
I will probably post v2 after net-next opens for 5.10.
I wanted to get some reviews on this patch before net-next closes for
the merge window.
Dan
next prev parent reply other threads:[~2020-10-08 17:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-08 16:23 [PATCH net-next 0/2] DP83TD510 Single Pair 10Mbps Ethernet PHY Dan Murphy
2020-10-08 16:23 ` [PATCH net-next 1/2] dt-bindings: dp83td510: Add binding for DP83TD510 " Dan Murphy
2020-10-08 17:11 ` Florian Fainelli
2020-10-08 18:18 ` Dan Murphy
2020-10-08 16:23 ` [PATCH net-next 2/2] net: phy: dp83td510: Add support for the " Dan Murphy
2020-10-08 16:51 ` Heiner Kallweit
2020-10-08 17:00 ` Dan Murphy [this message]
2020-10-16 22:02 ` Andrew Lunn
2020-10-19 21:33 ` Dan Murphy
2020-10-19 21:55 ` Andrew Lunn
2020-10-19 22:04 ` Dan Murphy
2020-10-20 12:00 ` Dan Murphy
2020-10-20 13:46 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2baf2f6a-bad1-d008-fa11-3389c6b38f5b@ti.com \
--to=dmurphy@ti.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).