From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7B0EC43381 for ; Fri, 1 Mar 2019 09:23:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AD49A2085A for ; Fri, 1 Mar 2019 09:23:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=synopsys.com header.i=@synopsys.com header.b="dFpzn78n" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727920AbfCAJXc (ORCPT ); Fri, 1 Mar 2019 04:23:32 -0500 Received: from smtprelay.synopsys.com ([198.182.47.9]:47422 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728208AbfCAJXc (ORCPT ); Fri, 1 Mar 2019 04:23:32 -0500 Received: from mailhost.synopsys.com (badc-mailhost1.synopsys.com [10.192.0.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtprelay.synopsys.com (Postfix) with ESMTPS id D1CFD24E1D11; Fri, 1 Mar 2019 01:23:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=synopsys.com; s=mail; t=1551432211; bh=cI3PdUj/O9OtmYuPA/xrXo8amR4cS5bIQkF6J577VpI=; h=Subject:To:CC:References:From:Date:In-Reply-To:From; b=dFpzn78nFQuvSejEcO5fHEeHDcPJdYL3lJw8shMLTR4HPsiRjwx/iss4q+wfnGjkY gBw+quCktkTduDjw6jbeD3a0q38TS1kUmizKh5hzVRaPS9i1gDzAFOJTnGJbUQrb/V N9tU9UFSH7mNXhlW0mEDoAa/g8QSYoaKm3rDJhsEjOiZ84a9mAlOKAUUd2DVjfCGtl 3PJM5UzAIOF4ayeK0T4GSI4zs0QyrCfxXYiffh58XNhFHP/5fTB3zCADMeiOrMVEen d02yNZvKh0webkpTaulr61At6XG+QDNcoazLAeNXCqYhwDPQ+2J1EJM4HQ6ko/BGpB Rc9pj/XKw4ooA== Received: from US01WEHTC3.internal.synopsys.com (us01wehtc3.internal.synopsys.com [10.15.84.232]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mailhost.synopsys.com (Postfix) with ESMTPS id A9BFFA0079; Fri, 1 Mar 2019 09:23:26 +0000 (UTC) Received: from DE02WEHTCB.internal.synopsys.com (10.225.19.94) by US01WEHTC3.internal.synopsys.com (10.15.84.232) with Microsoft SMTP Server (TLS) id 14.3.408.0; Fri, 1 Mar 2019 01:23:26 -0800 Received: from DE02WEHTCA.internal.synopsys.com (10.225.19.92) by DE02WEHTCB.internal.synopsys.com (10.225.19.94) with Microsoft SMTP Server (TLS) id 14.3.408.0; Fri, 1 Mar 2019 10:23:24 +0100 Received: from [10.107.19.176] (10.107.19.176) by DE02WEHTCA.internal.synopsys.com (10.225.19.80) with Microsoft SMTP Server (TLS) id 14.3.408.0; Fri, 1 Mar 2019 10:23:23 +0100 Subject: Re: stmmac / meson8b-dwmac To: Simon Huelck , Jose Abreu , Sebastian Gottschall , Jerome Brunet , Martin Blumenstingl CC: , , , Emiliano Ingrassia , References: <8bae9cd6-5c44-30e3-bfe5-8d6f853f170e@synopsys.com> <065407cd-c13b-e74c-7798-508650c12caf@gmx.de> <227be4e9-b0cc-a011-2558-71a17567246f@synopsys.com> <45e73e8c-a0fb-6f8f-8dc6-3aa2103fdda3@gmx.de> <4493b245-de93-46cd-327b-8091a3babc3a@gmx.de> <244d7c74-e0ca-a9c7-f4b0-3de7bec4024b@gmx.de> <1426d8ed40be0927c135aff25dcf989a11326932.camel@baylibre.com> <9074d29b-4cc9-87b6-009f-48280a4692c0@gmx.de> <8ec64936-c8fa-1f0e-68bf-2ad1d6e8f5d9@gmx.de> <3a040370-e7e5-990e-81dc-8e9bb0ab7761@gmx.de> <12d1d6de-2905-46a8-6481-d6f20c8e9d85@gmx.de> From: Jose Abreu Message-ID: <2c4d9726-6c2a-cd95-0493-323f5f09e14a@synopsys.com> Date: Fri, 1 Mar 2019 09:23:22 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <12d1d6de-2905-46a8-6481-d6f20c8e9d85@gmx.de> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [10.107.19.176] Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi Simon, On 2/27/2019 7:02 PM, Simon Huelck wrote: > Hi, > > > the thing is , that im not a stmmac developer. Yes , maybe i can bissect > it and yes you are lucky since im a C-developer since a long time for > embedded systems. > > The problem is that i dont understand the structure of stmmac and im not > aware of any documentation about the driver structure nor the underlying > ethernet hardware ( even though im used to ethernet hardware in embedded > environment ). So how shall i recognize the relevant change between > 4.14.29 and 5.0rc8 ? > > > Is it in the DTS/DTB, wrong hardware description ? Is it in the code ? > how is the duplex hardware working on this piece ? > > I can try to support you the best i can, but i have little chances to > analyze it myself. At which measurements / counters is it possible to > see that duplex is fully working ?  Why did even the non-duplex > bandwidth regress from 900MBits to 650 ? Why is that 650 MBits dividing > up to TX and RX in summary when doing duplex ? Why is TX not starving in > duplex but RX ? > > From my point of view should be the following things given: > - the non duplex bandwidth should be somewhere around 900MBits , the HW > is capable of that > - TX should not influence RX or vice versa in duplex > - the duplex bandwidth should be 900MBits in both directions ( maybe a > bit asymetric when buffers in both dirs are not same ) > > I guess we need some profiling on stmmac and ( at least i need ) more > knowledge of the hardware and stmmac itself. Can someone point me to the > driver documentation, describing the functions in the code and the > structure ? How can i profile stmmac ( usually im using hardware / JTAG > debuggers at work, but here @home i got nothing like that ) > > So how do we continue ? When I said bissect I was meaning GIT Bissect [1]. You shouldn't need any development background for this. You just have to start bissect, compile, test and check if commit is good or not. I'm not very familiar with this feature but I think you can bissect pretty fast if you say you just want stmmac commits, check ("Cutting down bisection by giving more parameters to bisect start") on previous link ... In your case it would be stmmac changes, dts, and phy. [1] https://git-scm.com/docs/git-bisect Thanks, Jose Miguel Abreu