From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Oliver Hartkopp <socketcan@hartkopp.net>, linux-can@vger.kernel.org
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH can-next] can: add ISO 15765-2:2016 transport protocol
Date: Tue, 6 Oct 2020 22:27:40 +0200 [thread overview]
Message-ID: <2cadd37a-bfca-097b-a957-864298b104f9@pengutronix.de> (raw)
In-Reply-To: <20200928200404.82229-1-socketcan@hartkopp.net>
[-- Attachment #1.1: Type: text/plain, Size: 1487 bytes --]
On 9/28/20 10:04 PM, Oliver Hartkopp wrote:
> CAN Transport Protocols offer support for segmented Point-to-Point
> communication between CAN nodes via two defined CAN Identifiers.
> As CAN frames can only transport a small amount of data bytes
> (max. 8 bytes for 'classic' CAN and max. 64 bytes for CAN FD) this
> segmentation is needed to transport longer PDUs as needed e.g. for
> vehicle diagnosis (UDS, ISO 14229) or IP-over-CAN traffic.
> This protocol driver implements data transfers according to
> ISO 15765-2:2016 for 'classic' CAN and CAN FD frame types.
>
> Signed-off-by: Oliver Hartkopp <socketcan@hartkopp.net>
Applied to linux-can-next with some changes:
> diff --git a/net/can/isotp.c b/net/can/isotp.c
> new file mode 100644
> index 000000000000..efed3e47b6ee
> --- /dev/null
> +++ b/net/can/isotp.c
> @@ -0,0 +1,1428 @@
> +// SPDX-License-Identifier: ((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause)
Removed the syscall note, as it's only ment for header files. See:
d77cd7fefc0d can: remove "WITH Linux-syscall-note" fro
SPDX tag of C files
Further I've fixes some indention, a checkpatch warning and some typos.
regards,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-10-06 20:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-28 20:04 [PATCH can-next] can: add ISO 15765-2:2016 transport protocol Oliver Hartkopp
2020-10-06 7:19 ` Oliver Hartkopp
2020-10-06 7:21 ` Oliver Hartkopp
2020-10-06 20:27 ` Marc Kleine-Budde [this message]
2020-10-07 7:26 ` Oliver Hartkopp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2cadd37a-bfca-097b-a957-864298b104f9@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=linux-can@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=socketcan@hartkopp.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).