From: Jacob Keller <jacob.e.keller@intel.com>
To: David Ahern <dsahern@gmail.com>,
netdev@vger.kernel.org,
Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [iproute2-next v2 5/5] devlink: support setting the overwrite mask
Date: Tue, 4 Aug 2020 11:31:04 -0700 [thread overview]
Message-ID: <2cea2823-3885-4576-12e9-8c3f58518d2e@intel.com> (raw)
In-Reply-To: <b22c5b28-71f4-d9c1-f619-783f601dd653@gmail.com>
On 8/3/2020 4:54 PM, David Ahern wrote:
> On 8/3/20 5:30 PM, Jacob Keller wrote:
>>
>> Slightly unrelated: but the recent change to using a bitfield32 results
>> in a "GENMASK is undefined".. I'm not sure what the proper way to fix
>> this is, since we'd like to still use GENMASK to define the supported
>> bitfields. I guess we need to pull in more headers? Or define something
>> in include/utils.h?
>>
>
> I see that include/linux/bits.h has been pulled into the tools directory
> for perf and power tools (ie., works fine in userspace).
>
> iproute2 is GPL so should be good from a licensing perspective to copy
> into iproute2. Stephen: any objections?
>
Hmm... Actually, no other uapi header uses GENMASK.. Perhaps its better
to just avoid using it in the uapi/linux/devlink.h header...
next prev parent reply other threads:[~2020-08-04 18:31 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-01 0:21 [net-next v2 0/5] devlink flash update overwrite mask Jacob Keller
2020-08-01 0:21 ` [net-next v2 1/5] devlink: convert flash_update to use params structure Jacob Keller
2020-08-03 15:46 ` Jiri Pirko
2020-08-01 0:21 ` [net-next v2 2/5] devlink: introduce flash update overwrite mask Jacob Keller
2020-08-03 15:38 ` Jiri Pirko
2020-08-03 16:53 ` Jacob Keller
2020-08-03 23:08 ` Jacob Keller
2020-08-01 0:21 ` [net-next v2 3/5] ice: add support for " Jacob Keller
2020-08-01 0:21 ` [iproute2-next v2 4/5] Update devlink header for overwrite mask attribute Jacob Keller
2020-08-01 0:21 ` [iproute2-next v2 5/5] devlink: support setting the overwrite mask Jacob Keller
2020-08-03 15:53 ` David Ahern
2020-08-03 16:20 ` Jiri Pirko
2020-08-03 16:56 ` Jacob Keller
2020-08-03 21:20 ` David Ahern
2020-08-03 22:44 ` Jacob Keller
2020-08-03 23:30 ` Jacob Keller
2020-08-03 23:54 ` David Ahern
2020-08-04 18:31 ` Jacob Keller [this message]
2020-08-03 15:28 ` [net-next v2 0/5] devlink flash update " Jiri Pirko
2020-08-03 16:51 ` Jacob Keller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2cea2823-3885-4576-12e9-8c3f58518d2e@intel.com \
--to=jacob.e.keller@intel.com \
--cc=dsahern@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).