From: Paul Menzel <pmenzel@molgen.mpg.de>
To: Aaron Ma <aaron.ma@canonical.com>,
Hans de Goede <hdegoede@redhat.com>,
Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
davem@davemloft.net, intel-wired-lan@lists.osuosl.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
sasha.neftin@intel.com
Subject: Re: [Intel-wired-lan] [PATCH] e1000e: bump up timeout to wait when ME un-configure ULP mode
Date: Fri, 3 Apr 2020 09:37:26 +0200 [thread overview]
Message-ID: <2d7c1890-9cd8-8134-af12-5c55cd7e1a8e@molgen.mpg.de> (raw)
In-Reply-To: <1c0e602f-1fe7-62b1-2283-b98783782e87@canonical.com>
Dear Linux folks,
Am 03.04.20 um 05:15 schrieb Aaron Ma:
> I have received the email that you apply this patch to next-queue branch
> dev-queue.
>
> But after this branch is rebased to v5.6, I can't find it.
>
> Will you apply again?
I really urge you to write more elaborate commit messages.
The exact error is not listed. The known regressed devices are not
listed, so possible testers cannot easily test or affected people cannot
find it, when searching the Linux git history.
How did you find out, that ME takes more than two seconds?
Also, it’s not clear, what effect increasing the timeout has. Does the
whole resume process take longer or just getting the Ethernet device
back up?
Lastly, in case of the timeout, an error message should be printed, so
people with even more broken ME devices, get a clue.
Without this information, how can anybody know, if this is the right fix
and distributions, if it should be backported?
Kind regards,
Paul
next prev parent reply other threads:[~2020-04-03 7:37 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-23 19:16 [PATCH] e1000e: bump up timeout to wait when ME un-configure ULP mode Aaron Ma
2020-03-25 4:17 ` Kai-Heng Feng
2020-03-25 6:36 ` Neftin, Sasha
2020-03-25 6:39 ` Kai-Heng Feng
2020-03-25 6:42 ` Tsai, Rex
2020-03-25 6:49 ` Aaron Ma
2020-03-25 6:43 ` Aaron Ma
2020-03-25 13:58 ` Neftin, Sasha
2020-03-25 14:07 ` Aaron Ma
2020-03-25 15:49 ` [Intel-wired-lan] " Paul Menzel
2020-03-26 11:29 ` Kai-Heng Feng
2020-03-26 11:41 ` Paul Menzel
2020-03-28 10:55 ` David Laight
2020-04-02 12:31 ` Hans de Goede
2020-04-03 3:15 ` Aaron Ma
2020-04-03 7:37 ` Paul Menzel [this message]
2020-04-05 6:46 ` Neftin, Sasha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2d7c1890-9cd8-8134-af12-5c55cd7e1a8e@molgen.mpg.de \
--to=pmenzel@molgen.mpg.de \
--cc=aaron.ma@canonical.com \
--cc=davem@davemloft.net \
--cc=hdegoede@redhat.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sasha.neftin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).