From: "Jubran, Samih" <sameehj@amazon.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"Kiyanovski, Arthur" <akiyano@amazon.com>,
"Woodhouse, David" <dwmw@amazon.co.uk>,
"Machulsky, Zorik" <zorik@amazon.com>,
"Matushevsky, Alexander" <matua@amazon.com>,
"Bshara, Saeed" <saeedb@amazon.com>,
"Wilson, Matt" <msw@amazon.com>,
"Liguori, Anthony" <aliguori@amazon.com>,
"Bshara, Nafea" <nafea@amazon.com>,
"Tzalik, Guy" <gtzalik@amazon.com>,
"Belgazal, Netanel" <netanel@amazon.com>,
"Saidi, Ali" <alisaidi@amazon.com>,
"Herrenschmidt, Benjamin" <benh@amazon.com>,
"Dagan, Noam" <ndagan@amazon.com>
Subject: RE: [PATCH V2 net-next 11/13] net: ena: move llq configuration from ena_probe to ena_device_init()
Date: Sun, 3 May 2020 09:54:45 +0000 [thread overview]
Message-ID: <2dc068f499bb4053923d08d08e4e5dcc@EX13D11EUC003.ant.amazon.com> (raw)
In-Reply-To: <20200428124621.0ce3dc5c@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
> -----Original Message-----
> From: Jakub Kicinski <kuba@kernel.org>
> Sent: Tuesday, April 28, 2020 10:46 PM
> To: Jubran, Samih <sameehj@amazon.com>
> Cc: davem@davemloft.net; netdev@vger.kernel.org; Kiyanovski, Arthur
> <akiyano@amazon.com>; Woodhouse, David <dwmw@amazon.co.uk>;
> Machulsky, Zorik <zorik@amazon.com>; Matushevsky, Alexander
> <matua@amazon.com>; Bshara, Saeed <saeedb@amazon.com>; Wilson,
> Matt <msw@amazon.com>; Liguori, Anthony <aliguori@amazon.com>;
> Bshara, Nafea <nafea@amazon.com>; Tzalik, Guy <gtzalik@amazon.com>;
> Belgazal, Netanel <netanel@amazon.com>; Saidi, Ali
> <alisaidi@amazon.com>; Herrenschmidt, Benjamin <benh@amazon.com>;
> Dagan, Noam <ndagan@amazon.com>
> Subject: RE: [EXTERNAL] [PATCH V2 net-next 11/13] net: ena: move llq
> configuration from ena_probe to ena_device_init()
>
> CAUTION: This email originated from outside of the organization. Do not click
> links or open attachments unless you can confirm the sender and know the
> content is safe.
>
>
>
> On Tue, 28 Apr 2020 07:27:24 +0000 sameehj@amazon.com wrote:
> > + ena_dev->mem_bar = devm_ioremap_wc(&pdev->dev,
> > + pci_resource_start(pdev, ENA_MEM_BAR),
> > + pci_resource_len(pdev, ENA_MEM_BAR));
>
> Is there anything that'd undo the mapping in case of reset?
>
> The use of devm_ functions outside of probe seems questionable.
I agree, dropped patch in v3.
next prev parent reply other threads:[~2020-05-03 9:54 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-28 7:27 [PATCH V2 net-next 00/13] Enhance current features in ena driver sameehj
2020-04-28 7:27 ` [PATCH V2 net-next 01/13] net: ena: avoid unnecessary admin command when RSS function set fails sameehj
2020-04-28 7:27 ` [PATCH V2 net-next 02/13] net: ena: fix error returning in ena_com_get_hash_function() sameehj
2020-04-28 7:27 ` [PATCH V2 net-next 03/13] net: ena: allow setting the hash function without changing the key sameehj
2020-04-28 7:27 ` [PATCH V2 net-next 04/13] net: ena: change default RSS hash function to Toeplitz sameehj
2020-04-28 7:27 ` [PATCH V2 net-next 05/13] net: ena: changes to RSS hash key allocation sameehj
2020-04-28 7:27 ` [PATCH V2 net-next 06/13] net: ena: remove code that does nothing sameehj
2020-04-28 7:27 ` [PATCH V2 net-next 07/13] net: ena: add unmask interrupts statistics to ethtool sameehj
2020-04-28 7:27 ` [PATCH V2 net-next 08/13] net: ena: add support for reporting of packet drops sameehj
2020-04-28 7:27 ` [PATCH V2 net-next 09/13] net: ena: implement ena_com_get_admin_polling_mode() sameehj
2020-04-28 19:04 ` Jakub Kicinski
2020-05-03 9:54 ` Jubran, Samih
2020-04-28 7:27 ` [PATCH V2 net-next 10/13] net: ena: use SHUTDOWN as reset reason when closing interface sameehj
2020-04-28 7:27 ` [PATCH V2 net-next 11/13] net: ena: move llq configuration from ena_probe to ena_device_init() sameehj
2020-04-28 19:46 ` Jakub Kicinski
2020-05-03 9:54 ` Jubran, Samih [this message]
2020-04-28 7:27 ` [PATCH V2 net-next 12/13] net: ena: cosmetic: remove unnecessary spaces and tabs in ena_com.h macros sameehj
2020-04-28 7:27 ` [PATCH V2 net-next 13/13] net: ena: cosmetic: extract code to ena_indirection_table_set() sameehj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2dc068f499bb4053923d08d08e4e5dcc@EX13D11EUC003.ant.amazon.com \
--to=sameehj@amazon.com \
--cc=akiyano@amazon.com \
--cc=aliguori@amazon.com \
--cc=alisaidi@amazon.com \
--cc=benh@amazon.com \
--cc=davem@davemloft.net \
--cc=dwmw@amazon.co.uk \
--cc=gtzalik@amazon.com \
--cc=kuba@kernel.org \
--cc=matua@amazon.com \
--cc=msw@amazon.com \
--cc=nafea@amazon.com \
--cc=ndagan@amazon.com \
--cc=netanel@amazon.com \
--cc=netdev@vger.kernel.org \
--cc=saeedb@amazon.com \
--cc=zorik@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).