From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 591EBC282CE for ; Tue, 4 Jun 2019 23:30:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3132D206B8 for ; Tue, 4 Jun 2019 23:30:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LrIX7lxp" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726992AbfFDXaj (ORCPT ); Tue, 4 Jun 2019 19:30:39 -0400 Received: from mail-pf1-f193.google.com ([209.85.210.193]:45477 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727038AbfFDXai (ORCPT ); Tue, 4 Jun 2019 19:30:38 -0400 Received: by mail-pf1-f193.google.com with SMTP id s11so13632221pfm.12 for ; Tue, 04 Jun 2019 16:30:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=kok+2ExJE3lrSQbKneSABeGL6ccrlQqra2bTnD6KA4s=; b=LrIX7lxpEbA5mg54lfSOJBu1PKzEemDRlsV/bNDBatd6TvvdlNHXwIBy/9Q319DdGb KztlVwLsgy2rdDSAkjpnZjsY/UkOLg6m5ikixf/VyKX/61DgMIkLtOmeywxrRD5gZ4Im J0r80mLR+3vuyp87/RLv8YuV8xUmiR+FXJ5ViibhzejPG4aooaZXZiqwBSNPzCSq1CiP KaHqslkm4R6MXxh5TpXKZiWibbdyV83eW0XG6C6qgd2+vqMw6w+/oXtpBsabolhMCc6K NI2IiKeSHGS6hfQStvCaw0XYoY+K01TDAKnSmYPUv/9GAkViQdd2xg+uh8f+NZ6QfeJk 2sYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=kok+2ExJE3lrSQbKneSABeGL6ccrlQqra2bTnD6KA4s=; b=eVso3F0VWq+OkSOhJQhb8rNLkEfpAIq38mSshpYHddDwqjlFylWE0bp7smC2w3ZeMp Bj71gVXp24IeMojLskFurEPEmhsUBGEut/Rx2zcwZlVJu1Vvg/KFCPX6Oe4iN8O+7N7n +xO20TeHs+Rc77+BKknKJ/ndnRrhXUNqBOpE+8rbqOGhx38/CFqrdrxFwdlZt+8+sFyn r4vuVmiCNFxc1Xw5rbe/o5+ygzA5DJRMbjduHrY5CftMOuXLIwKjuBWXF6n1kEs2zjOR OFRZWlBcZJpDWaFQIZXzhRbZ4dOWs53KADHAcIJ92tbum/dO3RmqOKFyh9iGuvHzvtok vqGA== X-Gm-Message-State: APjAAAVjLLoedCMIX+0/nb5OGUFBT2ZtFZDbILVM7xmNPzNp8xHmmCoV W9DsTzSbDxxoAoPm/kIgG3hXUtoBhyc= X-Google-Smtp-Source: APXvYqzRtGAIMOYya4dR3G3517k3hyCE4ilhVAhPwEmc3S7MC8Qh9HCJJiSWIQtVdVymzYySUe6x/Q== X-Received: by 2002:a65:5ccb:: with SMTP id b11mr397730pgt.172.1559691037649; Tue, 04 Jun 2019 16:30:37 -0700 (PDT) Received: from [172.27.227.186] ([216.129.126.118]) by smtp.googlemail.com with ESMTPSA id m5sm17477785pgc.84.2019.06.04.16.30.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Jun 2019 16:30:36 -0700 (PDT) Subject: Re: [PATCH v2 net-next 4/7] ipv6: Plumb support for nexthop object in a fib6_info To: Wei Wang Cc: Martin Lau , David Ahern , "David S . Miller" , Linux Kernel Network Developers , "idosch@mellanox.com" , "saeedm@mellanox.com" References: <5263d3ae-1865-d935-cb03-f6dfd4604d15@gmail.com> <4cdcdf65-4d34-603e-cb21-d649b399d760@gmail.com> <20190604005840.tiful44xo34lpf6d@kafai-mbp.dhcp.thefacebook.com> <453565b0-d08a-be96-3cd7-5608d4c21541@gmail.com> <20190604052929.4mlxa5sswm46mwrq@kafai-mbp.dhcp.thefacebook.com> <20190604210619.kq5jnkinak7izn2u@kafai-mbp.dhcp.thefacebook.com> <0c307c47-4cde-1e55-8168-356b2ef30298@gmail.com> From: David Ahern Message-ID: <2e8d7a07-d350-9d12-189b-d3a1be8cc69d@gmail.com> Date: Tue, 4 Jun 2019 17:30:34 -0600 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 6/4/19 3:36 PM, Wei Wang wrote: > instead of trying to convert ip6_create_rt_rcu() to use the pcpu_dst > logic, completely get rid of the calling to ip6_create_rt_rcu(), and > directly return f6i in those cases to the caller. Is that correct? yes