From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 426AFC46467 for ; Tue, 3 Jan 2023 13:27:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237065AbjACN1o (ORCPT ); Tue, 3 Jan 2023 08:27:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34198 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230488AbjACN1n (ORCPT ); Tue, 3 Jan 2023 08:27:43 -0500 X-Greylist: delayed 11191 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Tue, 03 Jan 2023 05:27:41 PST Received: from mail.3ffe.de (0001.3ffe.de [159.69.201.130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0527CD62; Tue, 3 Jan 2023 05:27:40 -0800 (PST) Received: from 3ffe.de (0001.3ffe.de [IPv6:2a01:4f8:c0c:9d57::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.3ffe.de (Postfix) with ESMTPSA id 7D8CC75; Tue, 3 Jan 2023 14:27:37 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walle.cc; s=mail2022082101; t=1672752457; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RHFL2PgwhVhLIbc4WDQ0VxcndRKF+zLEggh6iiwpmQY=; b=JhiJnwoTDE7pFhG+6yV7Aq3RJmVT4t44k3691eIxRvPtUQuqII3Y4xs+bhozbQ7LmK5Av2 XnALDQ/hF232xKSTXjfFhkMjHwMd/c5QRHY59HMdmYmiYrZAhxpuQ+9SD/TG0R+v9srIsp 6sFt2FSn0JXtJs+8pd5Ykp5vlR40Ln5+jh28Zd9+qn7D70QWQBIB3bWHOtVxvHSSNM+QO9 7Zn/Y7jwx1JKLDaslcRR/167IzifxZuNeCxzrblRR12xpOzbwFhEVaZafELh3c+/0a6vnJ sLt1tEtpRFKLBERSnf4b4UhQ79A3Sryb4YEu40MVBNv3nXhH+7zLGc/1riMTvQ== MIME-Version: 1.0 Date: Tue, 03 Jan 2023 14:27:37 +0100 From: Michael Walle To: Vladimir Oltean Cc: Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jose Abreu , Sergey Shtylyov , Wei Fang , Shenwei Wang , Clark Wang , NXP Linux Team , Sean Wang , Landen Chao , DENG Qingfang , Florian Fainelli , Matthias Brugger , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Andrew Lunn , Geert Uytterhoeven Subject: Re: [PATCH RFC net-next v2 06/12] net: mdio: mdio-bitbang: Separate C22 and C45 transactions In-Reply-To: <20230103131555.5i4tj7sk72gmed5d@skbuf> References: <20221227-v6-2-rc1-c45-seperation-v2-0-ddb37710e5a7@walle.cc> <20221227-v6-2-rc1-c45-seperation-v2-6-ddb37710e5a7@walle.cc> <20230103131555.5i4tj7sk72gmed5d@skbuf> User-Agent: Roundcube Webmail/1.4.13 Message-ID: <300bdff73f38b4e480d533c04126854d@walle.cc> X-Sender: michael@walle.cc Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Am 2023-01-03 14:15, schrieb Vladimir Oltean: > On Wed, Dec 28, 2022 at 12:07:22AM +0100, Michael Walle wrote: >> From: Andrew Lunn >> >> The bitbbanging bus driver can perform both C22 and C45 transfers. >> Create separate functions for each and register the C45 versions using >> the new driver API calls. >> >> The SH Ethernet driver places wrappers around these functions. In >> order to not break boards which might be using C45, add similar >> wrappers for C45 operations. >> >> Reviewed-by: Geert Uytterhoeven >> Signed-off-by: Andrew Lunn >> Signed-off-by: Michael Walle >> --- > > Incomplete conversion, this breaks the build. Need to update all users > of the bitbang driver (also davinci_mdio). Something like the diff > below > fixes that, but it leaves the davinci_mdio driver in a partially > converted state (if data->manual_mode is true, new API is used, > otherwise old API is used). So another patch to convert the other case > will likely be needed. The intel build bot already notified me about this. Unfortunately, only privately as I just noticed. And yes, these are just the first 12 patches of a larger series. -michael