From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E557C3F2D1 for ; Mon, 2 Mar 2020 22:35:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 44FDB2465D for ; Mon, 2 Mar 2020 22:35:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726780AbgCBWfZ (ORCPT ); Mon, 2 Mar 2020 17:35:25 -0500 Received: from mga02.intel.com ([134.134.136.20]:20605 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726744AbgCBWfZ (ORCPT ); Mon, 2 Mar 2020 17:35:25 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Mar 2020 14:35:25 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,508,1574150400"; d="scan'208";a="258122804" Received: from jekeller-mobl1.amr.corp.intel.com (HELO [134.134.177.106]) ([134.134.177.106]) by orsmga002.jf.intel.com with ESMTP; 02 Mar 2020 14:35:24 -0800 Subject: Re: [RFC PATCH v2 14/22] devlink: implement DEVLINK_CMD_REGION_NEW To: Jiri Pirko Cc: netdev@vger.kernel.org, valex@mellanox.com, linyunsheng@huawei.com, lihong.yang@intel.com, kuba@kernel.org References: <20200214232223.3442651-1-jacob.e.keller@intel.com> <20200214232223.3442651-15-jacob.e.keller@intel.com> <20200302174106.GC2168@nanopsycho> From: Jacob Keller Organization: Intel Corporation Message-ID: <3018db4c-1acc-cb56-07bd-33ffd9394726@intel.com> Date: Mon, 2 Mar 2020 14:35:24 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200302174106.GC2168@nanopsycho> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 3/2/2020 9:41 AM, Jiri Pirko wrote: >> struct devlink_region_ops { >> const char *name; >> void (*destructor)(const void *data); >> + int (*snapshot)(struct devlink *devlink, struct netlink_ext_ack *extack, >> + u8 **data); > > Please have the same type here and for destructor. "u8 *" I guess. > So... if I use void **data, this ends up looking a little weird because core code has to cast to (void **)... I agree it looks a bit odd to use u8 ** for snapshot and void * for the destructor. I really do not want to change destructor to u8 *, because that makes callers have to write a wrapper function if their destructor is simply kvfree. I'm ok with the cast to (void **) but it does seem a bit ugly. Thoughts on which approach to take, or to leave this as is? Thanks, Jake