From: Reindl Harald <h.reindl@thelounge.net>
To: Jozsef Kadlecsik <kadlec@netfilter.org>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>,
netfilter-devel@vger.kernel.org, davem@davemloft.net,
netdev@vger.kernel.org, kuba@kernel.org
Subject: Re: [PATCH net 1/4] netfilter: xt_recent: Fix attempt to update deleted entry
Date: Sun, 7 Feb 2021 17:34:51 +0100 [thread overview]
Message-ID: <3018f068-62b1-6dae-2dde-39d1a62fbcb2@thelounge.net> (raw)
In-Reply-To: <a51d867a-3ca9-fd36-528a-353aa6c42f42@thelounge.net>
Am 05.02.21 um 15:42 schrieb Reindl Harald:
>
>
> Am 05.02.21 um 14:54 schrieb Jozsef Kadlecsik:
>> Hi Harald,
>>
>> On Fri, 5 Feb 2021, Reindl Harald wrote:
>>
>>> "Reap only entries which won't be updated" sounds for me like the could
>>> be some optimization: i mean when you first update and then check what
>>> can be reaped the recently updated entry would not match to begin with
>>
>> When the entry is new and the given recent table is full we cannot update
>> (add) it, unless old entries are deleted (reaped) first. So it'd require
>> more additional checkings to be introduced to reverse the order of the
>> two
>> operations.
> well, the most important thing is that the firewall-vm stops to
> kernel-panic
why is that still not part of 5.10.14 given how old that issue is :-(
https://cdn.kernel.org/pub/linux/kernel/v5.x/ChangeLog-5.10.14
next prev parent reply other threads:[~2021-02-07 16:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-05 0:17 [PATCH net 0/4] Netfilter fixes for net Pablo Neira Ayuso
2021-02-05 0:17 ` [PATCH net 1/4] netfilter: xt_recent: Fix attempt to update deleted entry Pablo Neira Ayuso
2021-02-05 5:50 ` patchwork-bot+netdevbpf
2021-02-05 11:33 ` Reindl Harald
2021-02-05 13:54 ` Jozsef Kadlecsik
2021-02-05 14:42 ` Reindl Harald
2021-02-07 16:34 ` Reindl Harald [this message]
2021-02-07 19:38 ` Jozsef Kadlecsik
2021-02-10 10:34 ` Reindl Harald
2021-02-13 16:09 ` Reindl Harald
2021-02-13 16:21 ` Reindl Harald
2021-02-15 7:21 ` Jozsef Kadlecsik
2021-02-07 19:36 ` Jozsef Kadlecsik
2021-02-05 0:17 ` [PATCH net 2/4] selftests: netfilter: fix current year Pablo Neira Ayuso
2021-02-05 0:17 ` [PATCH net 3/4] netfilter: nftables: fix possible UAF over chains from packet path in netns Pablo Neira Ayuso
2021-02-05 0:17 ` [PATCH net 4/4] netfilter: flowtable: fix tcp and udp header checksum update Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3018f068-62b1-6dae-2dde-39d1a62fbcb2@thelounge.net \
--to=h.reindl@thelounge.net \
--cc=davem@davemloft.net \
--cc=kadlec@netfilter.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).