From: "Coelho, Luciano" <luciano.coelho@intel.com>
To: "kvalo@codeaurora.org" <kvalo@codeaurora.org>,
"tiwai@suse.de" <tiwai@suse.de>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH 1/2] iwlwifi: dbg: Don't touch the tlv data
Date: Tue, 12 Jan 2021 17:08:22 +0000 [thread overview]
Message-ID: <3022a89080907456096ef137ffad525fa134b081.camel@intel.com> (raw)
In-Reply-To: <s5h5z42qh2w.wl-tiwai@suse.de>
On Tue, 2021-01-12 at 17:02 +0100, Takashi Iwai wrote:
> On Tue, 12 Jan 2021 16:48:56 +0100,
> Kalle Valo wrote:
> >
> > Takashi Iwai <tiwai@suse.de> writes:
> >
> > > The commit ba8f6f4ae254 ("iwlwifi: dbg: add dumping special device
> > > memory") added a termination of name string just to be sure, and this
> > > seems causing a regression, a GPF triggered at firmware loading.
> > > Basically we shouldn't modify the firmware data that may be provided
> > > as read-only.
> > >
> > > This patch drops the code that caused the regression and keep the tlv
> > > data as is.
> > >
> > > Fixes: ba8f6f4ae254 ("iwlwifi: dbg: add dumping special device memory")
> > > BugLink: https://bugzilla.suse.com/show_bug.cgi?id=1180344
> > > BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=210733
> > > Signed-off-by: Takashi Iwai <tiwai@suse.de>
> >
> > I'm planning to queue this to v5.11. Should I add cc stable?
>
> Yes, it hits 5.10.y.
>
> > Luca, can I have your ack?
>
> It'd be great if this fix goes in quickly.
Thanks for the fix!
Acked-by: Luca Coelho <luciano.coelho@intel.com>
> BTW, I thought network people don't want to have Cc-to-stable in the
> patch, so I didn't put it by myself. Is this rule still valid?
In the wireless side of network, we've always used Cc stable when
needed, but the Fixes tag itself will almost always trigger the stable
people to take it anyway.
--
Cheers,
Luca.
next prev parent reply other threads:[~2021-01-12 17:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-12 13:24 [PATCH 0/2] iwlwifi: Fix a crash at loading Takashi Iwai
2021-01-12 13:24 ` [PATCH 1/2] iwlwifi: dbg: Don't touch the tlv data Takashi Iwai
2021-01-12 15:48 ` Kalle Valo
2021-01-12 16:02 ` Takashi Iwai
2021-01-12 17:08 ` Coelho, Luciano [this message]
2021-01-14 7:14 ` Kalle Valo
2021-01-14 16:57 ` [1/2] " Kalle Valo
2021-01-12 13:24 ` [PATCH 2/2] iwlwifi: dbg: Mark ucode tlv data as const Takashi Iwai
2021-01-12 15:50 ` Kalle Valo
2021-01-12 16:05 ` Takashi Iwai
2021-01-12 17:13 ` Coelho, Luciano
2021-01-13 6:50 ` Kalle Valo
2021-02-10 11:35 ` Luca Coelho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3022a89080907456096ef137ffad525fa134b081.camel@intel.com \
--to=luciano.coelho@intel.com \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).