From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Brown, Aaron F" Subject: RE: [Intel-wired-lan] [PATCH 1/2] igb: Teardown SR-IOV before unregister_netdev() Date: Tue, 11 Aug 2015 02:11:57 +0000 Message-ID: <309B89C4C689E141A5FF6A0C5FB2118B81AE35B1@ORSMSX101.amr.corp.intel.com> References: <20150727223753.10121.78169.stgit@gimli.home> <20150727231834.10121.62918.stgit@gimli.home> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT Cc: "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" To: Alex Williamson , "intel-wired-lan@lists.osuosl.org" , "Kirsher, Jeffrey T" Return-path: In-Reply-To: <20150727231834.10121.62918.stgit@gimli.home> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org > From: Intel-wired-lan [mailto:intel-wired-lan-bounces@lists.osuosl.org] On > Behalf Of Alex Williamson > Sent: Monday, July 27, 2015 4:19 PM > To: intel-wired-lan@lists.osuosl.org; Kirsher, Jeffrey T > Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: [Intel-wired-lan] [PATCH 1/2] igb: Teardown SR-IOV before > unregister_netdev() > > When the .remove() callback for a PF is called, SR-IOV support for the > device is disabled, which requires unbinding and removing the VFs. > The VFs may be in-use either by the host kernel or userspace, such as > assigned to a VM through vfio-pci. In this latter case, the VFs may > be removed either by shutting down the VM or hot-unplugging the > devices from the VM. Unfortunately in the case of a Windows 2012 R2 > guest, hot-unplug is broken due to the ordering of the PF driver > teardown. Disabling SR-IOV prior to unregister_netdev() avoids this > issue. > > Signed-off-by: Alex Williamson > --- > drivers/net/ethernet/intel/igb/igb_main.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) Tested-by: Aaron Brown