From: "Brown, Aaron F" <aaron.f.brown@intel.com>
To: "Björn Töpel" <bjorn.topel@gmail.com>,
"intel-wired-lan@lists.osuosl.org"
<intel-wired-lan@lists.osuosl.org>
Cc: "Topel, Bjorn" <bjorn.topel@intel.com>,
"Karlsson, Magnus" <magnus.karlsson@intel.com>,
"magnus.karlsson@gmail.com" <magnus.karlsson@gmail.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"Sokolowski, Jan" <jan.sokolowski@intel.com>
Subject: RE: [PATCH 2/2] i40e: add tracking of AF_XDP ZC state for each queue pair
Date: Sat, 16 Feb 2019 02:54:53 +0000 [thread overview]
Message-ID: <309B89C4C689E141A5FF6A0C5FB2118B96641EE4@ORSMSX101.amr.corp.intel.com> (raw)
In-Reply-To: <20190212085205.7848-3-bjorn.topel@gmail.com>
> From: netdev-owner@vger.kernel.org [mailto:netdev-
> owner@vger.kernel.org] On Behalf Of Björn Töpel
> Sent: Tuesday, February 12, 2019 12:52 AM
> To: intel-wired-lan@lists.osuosl.org
> Cc: Topel, Bjorn <bjorn.topel@intel.com>; Karlsson, Magnus
> <magnus.karlsson@intel.com>; magnus.karlsson@gmail.com;
> netdev@vger.kernel.org; Sokolowski, Jan <jan.sokolowski@intel.com>
> Subject: [PATCH 2/2] i40e: add tracking of AF_XDP ZC state for each queue
> pair
>
> From: Björn Töpel <bjorn.topel@intel.com>
>
> In commit f3fef2b6e1cc ("i40e: Remove umem from VSI") a regression was
> introduced; When the VSI was reset, the setup code would try to enable
> AF_XDP ZC unconditionally (as long as there was a umem placed in the
> netdev._rx struct). Here, we add a bitmap to the VSI that tracks if a
> certain queue pair has been "zero-copy enabled" via the ndo_bpf. The
> bitmap is used in i40e_xsk_umem, and enables zero-copy if and only if
> XDP is enabled, the corresponding qid in the bitmap is set and the
> umem is non-NULL.
>
> Fixes: f3fef2b6e1cc ("i40e: Remove umem from VSI")
> Signed-off-by: Björn Töpel <bjorn.topel@intel.com>
> ---
> drivers/net/ethernet/intel/i40e/i40e.h | 2 ++
> drivers/net/ethernet/intel/i40e/i40e_main.c | 10 +++++++++-
> drivers/net/ethernet/intel/i40e/i40e_xsk.c | 3 +++
> 3 files changed, 14 insertions(+), 1 deletion(-)
>
Tested-by: Aaron Brown <aaron.f.brown@intel.com>
prev parent reply other threads:[~2019-02-16 2:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-12 8:52 [PATCH 0/2] i40e: fix regression that enables AF_XDP ZC unconditionally Björn Töpel
2019-02-12 8:52 ` [PATCH 1/2] i40e: move i40e_xsk_umem function Björn Töpel
2019-02-16 2:54 ` Brown, Aaron F
2019-02-12 8:52 ` [PATCH 2/2] i40e: add tracking of AF_XDP ZC state for each queue pair Björn Töpel
2019-02-16 2:54 ` Brown, Aaron F [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=309B89C4C689E141A5FF6A0C5FB2118B96641EE4@ORSMSX101.amr.corp.intel.com \
--to=aaron.f.brown@intel.com \
--cc=bjorn.topel@gmail.com \
--cc=bjorn.topel@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jan.sokolowski@intel.com \
--cc=magnus.karlsson@gmail.com \
--cc=magnus.karlsson@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).