From: "Brown, Aaron F" <aaron.f.brown@intel.com>
To: Artem Bityutskiy <dedekind1@gmail.com>,
"David S. Miller" <davem@davemloft.net>
Cc: "Kirsher, Jeffrey T" <jeffrey.t.kirsher@intel.com>,
"Fujinaka, Todd" <todd.fujinaka@intel.com>,
"intel-wired-lan@lists.osuosl.org"
<intel-wired-lan@lists.osuosl.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH 1/2] net: intel: igb: minor ethool regdump amendment
Date: Fri, 21 Jun 2019 01:45:21 +0000 [thread overview]
Message-ID: <309B89C4C689E141A5FF6A0C5FB2118B970B125D@ORSMSX103.amr.corp.intel.com> (raw)
In-Reply-To: <20190618115513.99661-1-dedekind1@gmail.com>
On Tue, 2019-06-18 at 14:55 +0300, Artem Bityutskiy wrote:
> From: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
>
> This patch has no functional impact and it is just a preparation
> for the following patch. It removes an early return from the
> 'igb_get_regs()' function by moving the 82576-only registers
> dump into an "if" block. With this preparation, we can dump more
> non-82576 registers at the end of this function.
>
> Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
> ---
> drivers/net/ethernet/intel/igb/igb_ethtool.c | 70 ++++++++++----------
> 1 file changed, 35 insertions(+), 35 deletions(-)
>
Aside from teh missing "t" for ethtool in the subject that Andrew Lunn pointed out...
Tested-by: Aaron Brown <aaron.f.brown@intel.com>
prev parent reply other threads:[~2019-06-21 1:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-18 11:55 [PATCH 1/2] net: intel: igb: minor ethool regdump amendment Artem Bityutskiy
2019-06-18 11:55 ` [PATCH 2/2] net: intel: igb: add RR2DCDELAY to ethtool registers dump Artem Bityutskiy
2019-06-21 1:47 ` Brown, Aaron F
2019-06-18 13:58 ` [PATCH 1/2] net: intel: igb: minor ethool regdump amendment Andrew Lunn
2019-06-21 1:45 ` Brown, Aaron F [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=309B89C4C689E141A5FF6A0C5FB2118B970B125D@ORSMSX103.amr.corp.intel.com \
--to=aaron.f.brown@intel.com \
--cc=davem@davemloft.net \
--cc=dedekind1@gmail.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
--cc=todd.fujinaka@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).