From: Eric Dumazet <eric.dumazet@gmail.com>
To: Olga Albisser <olga@albisser.org>
Cc: Olga Albisser <olgabnd@gmail.com>,
netdev@vger.kernel.org,
Koen De Schepper <koen.de_schepper@nokia-bell-labs.com>,
Oliver Tilmans <olivier.tilmans@nokia-bell-labs.com>,
Bob Briscoe <research@bobbriscoe.net>,
Henrik Steen <henrist@henrist.net>
Subject: Re: [PATCH net-next] sched: add dualpi2 scheduler module
Date: Mon, 11 Mar 2019 09:08:15 -0700 [thread overview]
Message-ID: <30df7fd4-441e-925e-4078-2d1ff5dbc099@gmail.com> (raw)
In-Reply-To: <CANFQ_ZhUOXwiWhmgzN227htWh5Wxg5PHBxHNp=T1Z8YTu-=O5w@mail.gmail.com>
On 03/11/2019 09:00 AM, Olga Albisser wrote:
> Hi Eric,
>
> I thought the window opened roughly a week ago, and would be open for another week (since it's 2 weeks in total), have I misunderstood?
Yes, you have misunderstood.
When Linus opens his window, it is the time for maintainers to push their stuff to Linus,
and time for us to fix all the bugs.
At this moment, we are fixing the bugs that current merge window (for upcoming linux-5.1) is adding.
Please take a look at Documentation/networking/netdev-FAQ.rst around line 54.
Also we prefer not top-posting in netdev mailing list.
>
> Regards,
> Olga
>
> On Mon, Mar 11, 2019 at 4:41 PM Eric Dumazet <eric.dumazet@gmail.com <mailto:eric.dumazet@gmail.com>> wrote:
>
> FYI, net-next tree is currently closed.
>
> On 03/11/2019 08:14 AM, Olga Albisser wrote:
> > DUALPI2 provides extremely low latency & loss to traffic that uses a
> > scalable congestion controller (e.g. L4S, DCTCP) without degrading the
> > performance of 'classic' traffic (e.g. Reno, Cubic etc.). It is intended
> > to be the reference implementation of the IETF's DualQ Coupled AQM.
>
>
> > +
> > +static int dualpi2_qdisc_enqueue(struct sk_buff *skb, struct Qdisc *sch,
> > + struct sk_buff **to_free)
> > +{
> > + struct dualpi2_sched_data *q = qdisc_priv(sch);
> > + u32 ecn = get_ecn_field(skb);
> > + int err;
> > +
> > + /* set to the time the HTQ packet is in the Q */
> > + __net_timestamp(skb);
> > +
>
> You can not do that in a qdisc ( blindly overwriting skb->tstamp )
>
> EDT model was adopted in TCP in linux-4.20
>
> You will need to use part of skb->cb instead.
>
> BTW, prefer CLOCK_MONOTONIC, this can avoid all sort of surprises...
>
next prev parent reply other threads:[~2019-03-11 16:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-11 15:14 [PATCH net-next] sched: add dualpi2 scheduler module Olga Albisser
2019-03-11 15:41 ` Eric Dumazet
[not found] ` <CANFQ_ZhUOXwiWhmgzN227htWh5Wxg5PHBxHNp=T1Z8YTu-=O5w@mail.gmail.com>
2019-03-11 16:08 ` Eric Dumazet [this message]
2019-03-11 16:03 ` Eric Dumazet
2019-03-11 16:12 ` Eric Dumazet
2019-03-11 22:13 ` kbuild test robot
2019-03-14 16:48 ` Toke Høiland-Jørgensen
2019-03-14 17:18 ` Tilmans, Olivier (Nokia - BE/Antwerp)
2019-03-14 21:18 ` Toke Høiland-Jørgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=30df7fd4-441e-925e-4078-2d1ff5dbc099@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=henrist@henrist.net \
--cc=koen.de_schepper@nokia-bell-labs.com \
--cc=netdev@vger.kernel.org \
--cc=olga@albisser.org \
--cc=olgabnd@gmail.com \
--cc=olivier.tilmans@nokia-bell-labs.com \
--cc=research@bobbriscoe.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).