From: David Ahern <dsahern@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>, Guillaume Nault <gnault@redhat.com>
Cc: David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, Alexander Ovechkin <ovov@yandex-team.ru>
Subject: Re: [PATCH net 1/2] mpls: Make MPLS_IPTUNNEL select NET_MPLS_GSO
Date: Sun, 25 Oct 2020 20:48:38 -0600 [thread overview]
Message-ID: <310b13d1-4685-cd76-be5f-e9450fb6a95e@gmail.com> (raw)
In-Reply-To: <20201025144309.1c91b166@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
On 10/25/20 3:43 PM, Jakub Kicinski wrote:
> On Fri, 23 Oct 2020 20:48:16 +0200 Guillaume Nault wrote:
>> On Fri, Oct 23, 2020 at 11:23:04AM -0700, Jakub Kicinski wrote:
>>> On Fri, 23 Oct 2020 18:19:43 +0200 Guillaume Nault wrote:
>>>> Since commit b7c24497baea ("mpls: load mpls_gso after mpls_iptunnel"),
>>>> mpls_iptunnel.ko has a softdep on mpls_gso.ko. For this to work, we
>>>> need to ensure that mpls_gso.ko is built whenever MPLS_IPTUNNEL is set.
>>>
>>> Does it generate an error or a warning? I don't know much about soft
>>> dependencies, but I'd think it's optional.
>>
>> Yes, it's optional from a softdep point of view. My point was that
>> having a softdep isn't a complete solution, as a bad .config can still
>> result in inability to properly transmit GSO packets.
>
> IMO the combination of select and softdep feels pretty strange.
>
> It's either a softdep and therefore optional, or we really don't
> want to be missing it in a correctly functioning system, and the
> dependency should be made stronger.
>
That's why I liked the softdep solution - if the module is there, load it.
next prev parent reply other threads:[~2020-10-26 2:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-23 16:19 [PATCH net 0/2] mpls: fix dependencies on mpls_gso.ko Guillaume Nault
2020-10-23 16:19 ` [PATCH net 1/2] mpls: Make MPLS_IPTUNNEL select NET_MPLS_GSO Guillaume Nault
2020-10-23 18:23 ` Jakub Kicinski
2020-10-23 18:48 ` Guillaume Nault
2020-10-25 21:43 ` Jakub Kicinski
2020-10-26 2:48 ` David Ahern [this message]
2020-10-26 9:04 ` Guillaume Nault
2020-10-23 16:19 ` [PATCH net 2/2] net/sched: act_mpls: Add softdep on mpls_gso.ko Guillaume Nault
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=310b13d1-4685-cd76-be5f-e9450fb6a95e@gmail.com \
--to=dsahern@gmail.com \
--cc=davem@davemloft.net \
--cc=gnault@redhat.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ovov@yandex-team.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).