From: Daniel Borkmann <daniel@iogearbox.net>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>, davem@davemloft.net
Cc: netdev@vger.kernel.org, bpf@vger.kernel.org, kernel-team@fb.com,
linux-security-module@vger.kernel.org, acme@redhat.com,
jamorris@linux.microsoft.com, jannh@google.com,
kpsingh@google.com
Subject: Re: [PATCH v5 bpf-next 2/3] bpf: implement CAP_BPF
Date: Tue, 12 May 2020 22:27:33 +0200 [thread overview]
Message-ID: <311508c5-b80f-498e-2d0a-b98fe751ead9@iogearbox.net> (raw)
In-Reply-To: <20200508215340.41921-3-alexei.starovoitov@gmail.com>
On 5/8/20 11:53 PM, Alexei Starovoitov wrote:
[...]
> @@ -2880,8 +2933,6 @@ static int bpf_prog_test_run(const union bpf_attr *attr,
> struct bpf_prog *prog;
> int ret = -ENOTSUPP;
>
> - if (!capable(CAP_SYS_ADMIN))
> - return -EPERM;
Should above be under bpf_capable() as well or is the intention to really let
(fully) unpriv users run sk_filter test progs here? I would assume only progs
that have prior been loaded under bpf_capable() should suffice, so no need to
lower the bar for now, no?
> if (CHECK_ATTR(BPF_PROG_TEST_RUN))
> return -EINVAL;
>
> @@ -3163,7 +3214,7 @@ static int bpf_prog_get_info_by_fd(struct bpf_prog *prog,
> info.run_time_ns = stats.nsecs;
> info.run_cnt = stats.cnt;
>
> - if (!capable(CAP_SYS_ADMIN)) {
> + if (!bpf_capable()) {
Given the JIT dump this also exposes addresses when bpf_dump_raw_ok() passes.
I presume okay, but should probably be documented given CAP_SYS_ADMIN isn't
required anymore?
> info.jited_prog_len = 0;
> info.xlated_prog_len = 0;
> info.nr_jited_ksyms = 0;
> @@ -3522,7 +3573,7 @@ static int bpf_btf_load(const union bpf_attr *attr)
> if (CHECK_ATTR(BPF_BTF_LOAD))
> return -EINVAL;
>
> - if (!capable(CAP_SYS_ADMIN))
> + if (!bpf_capable())
> return -EPERM;
>
> return btf_new_fd(attr);
> @@ -3736,9 +3787,6 @@ static int link_create(union bpf_attr *attr)
> struct bpf_prog *prog;
> int ret;
>
> - if (!capable(CAP_NET_ADMIN))
> - return -EPERM;
> -
> if (CHECK_ATTR(BPF_LINK_CREATE))
> return -EINVAL;
>
> @@ -3784,9 +3832,6 @@ static int link_update(union bpf_attr *attr)
> u32 flags;
> int ret;
>
> - if (!capable(CAP_NET_ADMIN))
> - return -EPERM;
> -
> if (CHECK_ATTR(BPF_LINK_UPDATE))
> return -EINVAL;
>
next prev parent reply other threads:[~2020-05-12 20:27 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-08 21:53 [PATCH v5 bpf-next 0/3] Introduce CAP_BPF Alexei Starovoitov
2020-05-08 21:53 ` [PATCH v5 bpf-next 1/3] bpf, capability: " Alexei Starovoitov
2020-05-08 21:53 ` [PATCH v5 bpf-next 2/3] bpf: implement CAP_BPF Alexei Starovoitov
2020-05-12 0:12 ` sdf
2020-05-12 2:36 ` Alexei Starovoitov
2020-05-12 12:50 ` Jordan Glover
2020-05-12 15:46 ` Alexei Starovoitov
2020-05-12 15:54 ` sdf
2020-05-12 18:39 ` Alexei Starovoitov
2020-05-12 14:35 ` Daniel Borkmann
2020-05-12 18:25 ` Alexei Starovoitov
2020-05-12 20:07 ` Daniel Borkmann
2020-05-12 22:56 ` Alexei Starovoitov
2020-05-12 15:05 ` Daniel Borkmann
2020-05-12 18:29 ` Alexei Starovoitov
2020-05-12 20:09 ` Daniel Borkmann
2020-05-12 20:27 ` Daniel Borkmann [this message]
2020-05-12 23:01 ` Alexei Starovoitov
2020-05-08 21:53 ` [PATCH v5 bpf-next 3/3] selftests/bpf: use CAP_BPF and CAP_PERFMON in tests Alexei Starovoitov
2020-05-08 22:45 ` [PATCH v5 bpf-next 0/3] Introduce CAP_BPF Casey Schaufler
2020-05-08 23:00 ` Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=311508c5-b80f-498e-2d0a-b98fe751ead9@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=acme@redhat.com \
--cc=alexei.starovoitov@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=davem@davemloft.net \
--cc=jamorris@linux.microsoft.com \
--cc=jannh@google.com \
--cc=kernel-team@fb.com \
--cc=kpsingh@google.com \
--cc=linux-security-module@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).