From: Josh Hunt <johunt@akamai.com>
To: Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
Jason Baron <jbaron@akamai.com>
Cc: Alexander Duyck <alexander.duyck@gmail.com>,
David Miller <davem@davemloft.net>,
Netdev <netdev@vger.kernel.org>,
Willem de Bruijn <willemb@google.com>,
Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH net-next] gso: enable udp gso for virtual devices
Date: Fri, 9 Aug 2019 11:58:03 -0700 [thread overview]
Message-ID: <314b4ae8-ef99-e7a4-cb95-87b7ea74427f@akamai.com> (raw)
In-Reply-To: <CAF=yD-+zYGzTTYC-oYr392qugWiYpbgykMh1p8UrrgZ2ciR=aw@mail.gmail.com>
On 6/26/19 4:41 PM, Willem de Bruijn wrote:
> On Wed, Jun 26, 2019 at 3:17 PM Jason Baron <jbaron@akamai.com> wrote:
>>
>>
>>
>> On 6/14/19 4:53 PM, Jason Baron wrote:
>>>
>>>
>>> On 6/13/19 5:20 PM, Willem de Bruijn wrote:
>>>>>>> @@ -237,6 +237,7 @@ static inline int find_next_netdev_feature(u64 feature, unsigned long start)
>>>>>>> NETIF_F_GSO_GRE_CSUM | \
>>>>>>> NETIF_F_GSO_IPXIP4 | \
>>>>>>> NETIF_F_GSO_IPXIP6 | \
>>>>>>> + NETIF_F_GSO_UDP_L4 | \
>>>>>>> NETIF_F_GSO_UDP_TUNNEL | \
>>>>>>> NETIF_F_GSO_UDP_TUNNEL_CSUM)
>>>>>>
>>>>>> Are you adding this to NETIF_F_GSO_ENCAP_ALL? Wouldn't it make more
>>>>>> sense to add it to NETIF_F_GSO_SOFTWARE?
>>>>>>
>>>>>
>>>>> Yes, I'm adding to NETIF_F_GSO_ENCAP_ALL (not very clear from the
>>>>> context). I will fix the commit log.
>>>>>
>>>>> In: 83aa025 udp: add gso support to virtual devices, the support was
>>>>> also added to NETIF_F_GSO_ENCAP_ALL (although subsequently reverted due
>>>>> to UDP GRO not being in place), so I wonder what the reason was for that?
>>>>
>>>> That was probably just a bad choice on my part.
>>>>
>>>> It worked in practice, but if NETIF_F_GSO_SOFTWARE works the same
>>>> without unexpected side effects, then I agree that it is the better choice.
>>>>
>>>> That choice does appear to change behavior when sending over tunnel
>>>> devices. Might it send tunneled GSO packets over loopback?
>>>>
>>>>
>>>
>>> I set up a test case using fou tunneling through a bridge device using
>>> the udpgso_bench_tx test where packets are not received correctly if
>>> NETIF_F_GSO_UDP_L4 is added to NETIF_F_GSO_SOFTWARE. If I have it added
>>> to NETIF_F_GSO_ENCAP_ALL, it does work correctly. So there are more
>>> fixes required to include it in NETIF_F_GSO_SOFTWARE.
>>>
>>> The use-case I have only requires it to be in NETIF_F_GSO_ENCAP_ALL, but
>>> if it needs to go in NETIF_F_GSO_SOFTWARE, I can look at what's required
>>> more next week.
>>>
>>
>> Hi,
>>
>> I haven't had a chance to investigate what goes wrong with including
>> NETIF_F_GSO_UDP_L4 in NETIF_F_GSO_SOFTWARE - but I was just wondering if
>> people are ok with NETIF_F_GSO_UDP_L4 being added to
>> NETIF_F_GSO_ENCAP_ALL and not NETIF_F_GSO_SOFTWARE (ie the original
>> patch as posted)?
>>
>> As I mentioned that is sufficient for my use-case, and its how Willem
>> originally proposed this.
>
> Indeed, based on the previous discussion this sounds fine to me.
>
Willem
Are you OK to ACK this? If not, is there something else you'd rather see
here?
Thanks
Josh
next prev parent reply other threads:[~2019-08-09 18:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-12 23:12 [PATCH net-next] gso: enable udp gso for virtual devices Jason Baron
2019-06-13 17:15 ` Alexander Duyck
2019-06-13 19:03 ` Jason Baron
2019-06-13 21:20 ` Willem de Bruijn
2019-06-14 20:53 ` Jason Baron
2019-06-26 19:15 ` Jason Baron
2019-06-26 23:41 ` Willem de Bruijn
2019-08-09 18:58 ` Josh Hunt [this message]
2019-08-09 19:13 ` Willem de Bruijn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=314b4ae8-ef99-e7a4-cb95-87b7ea74427f@akamai.com \
--to=johunt@akamai.com \
--cc=alexander.duyck@gmail.com \
--cc=davem@davemloft.net \
--cc=jbaron@akamai.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=willemb@google.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).