Re: packet stuck in qdisc : patch proposal

From: Eric Dumazet <eric.dumazet@gmail.com>
To: Vincent Ray <vray@kalrayinc.com>, linyunsheng <linyunsheng@huawei.com>
Cc: davem <davem@davemloft.net>, 方国炬 <guoju.fgj@alibaba-inc.com>,
	kuba <kuba@kernel.org>, netdev <netdev@vger.kernel.org>,
	"Samuel Jones" <sjones@kalrayinc.com>,
	"vladimir oltean" <vladimir.oltean@nxp.com>,
	"Guoju Fang" <gjfang@linux.alibaba.com>,
	"Remy Gauguey" <rgauguey@kalrayinc.com>, will <will@kernel.org>,
	"Eric Dumazet" <edumazet@google.com>
Subject: Re: packet stuck in qdisc : patch proposal
Date: Tue, 24 May 2022 13:17:10 -0700	[thread overview]
Message-ID: <317a3e67-0956-e9c2-0406-9349844ca612@gmail.com> (raw)
In-Reply-To: <1675198168.15239468.1653411635290.JavaMail.zimbra@kalray.eu>

On 5/24/22 10:00, Vincent Ray wrote:
> All,
>
> I confirm Eric's patch works well too, and it's better and clearer than mine.
> So I think we should go for it, and the one from Guoju in addition.
>
> @Eric : I see you are one of the networking maintainers, so I have a few questions for you :
>
> a) are you going to take care of these patches directly yourself, or is there something Guoju or I should do to promote them ?

I think this is totally fine you take ownership of the patch, please 
send a formal V2.

Please double check what patchwork had to say about your V1 :

https://patchwork.kernel.org/project/netdevbpf/patch/1684598287.15044793.1653314052575.JavaMail.zimbra@kalray.eu/

And make sure to address the relevant points

The most important one is the lack of 'Signed-off-by:' tag, of course.

> b) Can we expect to see them land in the mainline soon ?

If your v2 submission is correct, it can be merged this week ;)

>
> c) Will they be backported to previous versions of the kernel ? Which ones ?

You simply can include a proper Fixes: tag, so that stable teams can 
backport

the patch to all affected kernel versions.

>
> Thanks a lot, best,

Thanks a lot for working on this long standing issue.