From: "Jonathan Lemon" <jonathan.lemon@gmail.com>
To: "Jakub Kicinski" <jakub.kicinski@netronome.com>
Cc: netdev@vger.kernel.org, bjorn.topel@intel.com,
magnus.karlsson@intel.com, saeedm@mellanox.com,
maximmi@mellanox.com, brouer@redhat.com, kernel-team@fb.com
Subject: Re: [PATCH 4/6 bfp-next] Simplify AF_XDP umem allocation path for Intel drivers.
Date: Thu, 27 Jun 2019 19:36:42 -0700 [thread overview]
Message-ID: <32DD3CE5-327F-4D76-861B-7256F3F10EC9@gmail.com> (raw)
In-Reply-To: <20190627154206.5d458e94@cakuba.netronome.com>
On 27 Jun 2019, at 15:42, Jakub Kicinski wrote:
> On Thu, 27 Jun 2019 15:08:34 -0700, Jonathan Lemon wrote:
>> Now that the recycle stack is always used for the driver umem path, the
>> driver code path can be simplified.
>>
>> Signed-off-by: Jonathan Lemon <jonathan.lemon@gmail.com>
>
> I guess it's a question to Bjorn and Magnus whether they want Intel
> drivers to always go through the reuse queue..
I did pass this by them earlier.
> Could you be more explicit on the motivation? I'd call this patch set
> "make all drivers use reuse queue" rather than "clean up".
The motivation is to have packets which were received on a zero-copy
AF_XDP socket, and which returned a TX verdict from the bpf program,
queued directly on the TX ring (if they're in the same napi context).
When these TX packets are completed, they are placed back onto the
reuse queue, as there isn't really any other place to handle them.
It also addresses Maxim's concern about having buffers end up sitting
on the rq after a ring resize.
I was going to send the TX change out as part of this patch, but
figured it would be better split unto its own series.
> Also when you're changing code please make sure you CC the author.
Who did I miss?
--
Jonathan
next prev parent reply other threads:[~2019-06-28 2:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-27 22:08 [PATCH 0/6 bpf-next] xsk: reuseq cleanup Jonathan Lemon
2019-06-27 22:08 ` [PATCH 1/6 bpf-next] Have xsk_umem_peek_addr_rq() return chunk-aligned handles Jonathan Lemon
2019-06-27 22:08 ` [PATCH 2/6 bpf-next] Clean up xsk reuseq API Jonathan Lemon
2019-06-27 22:38 ` Jakub Kicinski
2019-06-28 2:31 ` Jonathan Lemon
2019-06-28 20:41 ` Jakub Kicinski
2019-06-28 21:08 ` Jonathan Lemon
2019-07-01 9:58 ` Magnus Karlsson
2019-06-27 22:08 ` [PATCH 3/6 bpf-next] Always check the recycle stack when using the umem fq Jonathan Lemon
2019-06-27 22:08 ` [PATCH 4/6 bfp-next] Simplify AF_XDP umem allocation path for Intel drivers Jonathan Lemon
2019-06-27 22:42 ` Jakub Kicinski
2019-06-28 2:36 ` Jonathan Lemon [this message]
2019-06-28 20:48 ` Jakub Kicinski
2019-06-28 21:06 ` Jonathan Lemon
2019-06-27 22:08 ` [PATCH 5/6 bpf-next] Remove use of umem _rq variants from Mellanox driver Jonathan Lemon
2019-07-01 10:04 ` [PATCH 0/6 bpf-next] xsk: reuseq cleanup Magnus Karlsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32DD3CE5-327F-4D76-861B-7256F3F10EC9@gmail.com \
--to=jonathan.lemon@gmail.com \
--cc=bjorn.topel@intel.com \
--cc=brouer@redhat.com \
--cc=jakub.kicinski@netronome.com \
--cc=kernel-team@fb.com \
--cc=magnus.karlsson@intel.com \
--cc=maximmi@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=saeedm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).